diff options
| author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-16 11:45:17 +0000 |
|---|---|---|
| committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-16 11:45:17 +0000 |
| commit | 9061bee8add0e744e50811f7feb77333622775e3 (patch) | |
| tree | 84571937825706f13b75f1bf3c2967d969129a55 /build | |
| parent | 439589d72750b5e22a339834d7ed4a30c7166b58 (diff) | |
| download | chromium_src-9061bee8add0e744e50811f7feb77333622775e3.zip chromium_src-9061bee8add0e744e50811f7feb77333622775e3.tar.gz chromium_src-9061bee8add0e744e50811f7feb77333622775e3.tar.bz2 | |
Use PCH by default in VS 2010.
According to my testing, VS 2010 does not have problem (b) documented
at http://code.google.com/p/chromium/wiki/WindowsPrecompiledHeaders,
i.e. it rebuilds the PCH file when necessary because of
e.g. preprocessor flag changes.
Since we aren't using VS 2010 for official builds, if problem (a) (out
of memory) is encountered with VS 2010 when we make the switch to
using it for official builds, we can simply turn PCH off explicitly in
the include.gypi for the official bots.
This change has no effect on VS 2008 bots or users.
BUG=110001
Review URL: http://codereview.chromium.org/9139059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117845 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 27 |
1 files changed, 22 insertions, 5 deletions
diff --git a/build/common.gypi b/build/common.gypi index 154b947..755d526 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -251,11 +251,23 @@ # For example, use_xi2_mt=2 means XI2.2 or above version is required. 'use_xi2_mt%': 0, - # Use of precompiled headers on Windows is off by default - # because of complications that it can cause with our - # infrastructure (trybots etc.). Enable by setting to 1 in - # ~/.gyp/include.gypi or via the GYP command line for ~20-25% - # faster builds. + # Use of precompiled headers on Windows. + # + # This is on by default in VS 2010, but off by default for VS + # 2008 because of complications that it can cause with our + # trybots etc. + # + # This variable may be explicitly set to 1 (enabled) or 0 + # (disabled) in ~/.gyp/include.gypi or via the GYP command line. + # This setting will override the default. + # + # Note that a setting of 1 is probably suitable for most or all + # Windows developers using VS 2008, since precompiled headers + # provide a build speedup of 20-25%. There are a couple of + # small workarounds you may need to use when using VS 2008 (but + # not 2010), see + # http://code.google.com/p/chromium/wiki/WindowsPrecompiledHeaders + # for details. 'chromium_win_pch%': 0, 'conditions': [ @@ -365,6 +377,11 @@ }, { 'ui_compositor_image_transport%': 0, }], + + # Turn precompiled headers on by default for VS 2010. + ['OS=="win" and MSVS_VERSION=="2010"', { + 'chromium_win_pch%': 1 + }], ], }, |