diff options
| author | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 20:21:16 +0000 |
|---|---|---|
| committer | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-25 20:21:16 +0000 |
| commit | bd635c097dfc689674d6b21c006850a7b07f23f4 (patch) | |
| tree | b9c8bdf9edc379e288c14f64e063e29efe7635c8 /build | |
| parent | 19dc5d7922dc07b61c037ebbcc86f20dad27eab2 (diff) | |
| download | chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.zip chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.tar.gz chromium_src-bd635c097dfc689674d6b21c006850a7b07f23f4.tar.bz2 | |
Enable warning 4389 as an error on windows builds. This will make
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2081007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/build/common.gypi b/build/common.gypi index 0e66dba..be7a21e 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -554,6 +554,12 @@ # We use "POSIX" to refer to all non-Windows operating systems. ['OS=="win"', { 'sources/': [ ['exclude', '_posix\\.cc$'] ], + # turn on warnings for signed/unsigned mismatch on chromium code. + 'msvs_settings': { + 'VCCLCompilerTool': { + 'AdditionalOptions': ['/we4389'], + }, + }, }], # Though Skia is conceptually shared by Linux and Windows, # the only _skia files in our tree are Linux-specific. |