diff options
| author | mcgrathr <mcgrathr@chromium.org> | 2015-11-16 10:14:44 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-16 18:16:29 +0000 |
| commit | c3dcc79c556f87330d18703b538962c0d4c0a7e4 (patch) | |
| tree | 831cbbd990bb7b4b1228c4453a1dc778ad94696f /build | |
| parent | 65a9812e8f82bd73e8da2c1865db8d1e81b5d9e7 (diff) | |
| download | chromium_src-c3dcc79c556f87330d18703b538962c0d4c0a7e4.zip chromium_src-c3dcc79c556f87330d18703b538962c0d4c0a7e4.tar.gz chromium_src-c3dcc79c556f87330d18703b538962c0d4c0a7e4.tar.bz2 | |
GN: Disable strip in newlib_pnacl_nonsfi toolchain
The pnacl-strip tool does not grok the --strip-unneeded flag that
gcc_toolchain.gni uses. Disable stripping for this toolchain for now.
It can be reenabled soon after the tool has been updated.
BUG= 555741
R=dpranke@chromium.org, phosek@chromium.org
Review URL: https://codereview.chromium.org/1451783002
Cr-Commit-Position: refs/heads/master@{#359865}
Diffstat (limited to 'build')
| -rw-r--r-- | build/toolchain/nacl/BUILD.gn | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/build/toolchain/nacl/BUILD.gn b/build/toolchain/nacl/BUILD.gn index f36fba9..81cb995 100644 --- a/build/toolchain/nacl/BUILD.gn +++ b/build/toolchain/nacl/BUILD.gn @@ -28,7 +28,6 @@ nacl_arm_glibc_rev = revisions[1] #pnacl_newlib_rev = revisions[2] template("pnacl_toolchain") { - assert(defined(invoker.strip), "Must define strip") assert(defined(invoker.executable_extension), "Must define executable_extension") @@ -50,7 +49,9 @@ template("pnacl_toolchain") { ld = cxx readelf = toolprefix + "readelf" nm = toolprefix + "nm" - strip = toolprefix + invoker.strip + if (defined(invoker.strip)) { + strip = toolprefix + invoker.strip + } executable_extension = invoker.executable_extension } } @@ -70,8 +71,9 @@ pnacl_toolchain("newlib_pnacl") { pnacl_toolchain("newlib_pnacl_nonsfi") { executable_extension = "" - - strip = "strip" + # TODO(mcgrathr): Uncomment this after pnacl-strip has been taught + # to grok --strip-unneeded. + #strip = "strip" } template("nacl_glibc_toolchain") { |