diff options
| author | scottmg <scottmg@chromium.org> | 2015-01-07 16:36:27 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-08 00:37:14 +0000 |
| commit | df96803de2cef0a192ed5eb974d6d21400db5d8f (patch) | |
| tree | f0a8376e1e42a53d0e0eed101deb4ba5537fe649 /build | |
| parent | 4660f1d374d0ac51ab0b2349012004ae873469c7 (diff) | |
| download | chromium_src-df96803de2cef0a192ed5eb974d6d21400db5d8f.zip chromium_src-df96803de2cef0a192ed5eb974d6d21400db5d8f.tar.gz chromium_src-df96803de2cef0a192ed5eb974d6d21400db5d8f.tar.bz2 | |
Early error out if the 'msvs' is specified in GYP_GENERATORS
This generator hasn't worked for a long time, but it's not obvious
that it doesn't work which can be confusing.
R=thakis@chromium.org
BUG=446912
Review URL: https://codereview.chromium.org/797373004
Cr-Commit-Position: refs/heads/master@{#310421}
Diffstat (limited to 'build')
| -rwxr-xr-x | build/gyp_chromium | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/build/gyp_chromium b/build/gyp_chromium index ad2796b..1112575 100755 --- a/build/gyp_chromium +++ b/build/gyp_chromium @@ -275,6 +275,13 @@ if __name__ == '__main__': print 'Error: make gyp generator not supported (check GYP_GENERATORS).' sys.exit(1) + # We explicitly don't support the native msvs gyp generator. Be nice and + # fail here, rather than generating broken projects. + if re.search(r'(^|,|\s)msvs($|,|\s)', os.environ.get('GYP_GENERATORS', '')): + print 'Error: msvs gyp generator not supported (check GYP_GENERATORS).' + print 'Did you mean to use the `msvs-ninja` generator?' + sys.exit(1) + # If CHROMIUM_GYP_SYNTAX_CHECK is set to 1, it will invoke gyp with --check # to enfore syntax checking. syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK') |