summaryrefslogtreecommitdiffstats
path: root/build
diff options
context:
space:
mode:
authordpranke <dpranke@chromium.org>2015-09-22 14:49:55 -0700
committerCommit bot <commit-bot@chromium.org>2015-09-22 22:09:05 +0000
commite0f6a916e895a301edbf408b77068caa963cce31 (patch)
tree734b7413cc98b5b2395a8cede225e165995e5eec /build
parent4be57da557544e360ab73add1c9a2828299725f8 (diff)
downloadchromium_src-e0f6a916e895a301edbf408b77068caa963cce31.zip
chromium_src-e0f6a916e895a301edbf408b77068caa963cce31.tar.gz
chromium_src-e0f6a916e895a301edbf408b77068caa963cce31.tar.bz2
Various fixes for 32-bit Linux GN builds that need to be tracked down.
1) 64-bit gold linking doesn't work right 2) We need to compile d8 with the 32-bit clang toolchain to run the js browser tests 3) parts of mojo depend on cython which depends on the python sdks being present in the sysroot 4) we get errors trying to build the installer R=brettw@chromium.org, mcgrathr@chromium.org BUG= Review URL: https://codereview.chromium.org/1359513002 Cr-Commit-Position: refs/heads/master@{#350243}
Diffstat (limited to 'build')
-rw-r--r--build/config/compiler/BUILD.gn7
1 files changed, 4 insertions, 3 deletions
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index c822ca4..ea96f2e 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -44,9 +44,10 @@ declare_args() {
# Requires profiling to be set to true.
enable_full_stack_frames_for_profiling = false
- # Use 64-bit gold for linking on both 64-bit Linux and 32-bit linux;
- # 32-bit Gold runs out of address-space on 32-bit bit builds.
- use_gold = is_linux && (current_cpu == "x64" || current_cpu == "x86")
+ # TODO(GYP): We should be using 64-bit gold for linking on both 64-bit Linux
+ # and 32-bit linux; 32-bit Gold runs out of address-space on 32-bit builds.
+ # However, something isn't quite working right on the 32-bit builds.
+ use_gold = is_linux && current_cpu == "x64"
# When we are going to use gold we need to find it.
if (use_gold) {