Run findbugs and findbugs-plugin test on clang bot.

- Also rebaseline the known bugs.

BUG=156116


Review URL: https://chromiumcodereview.appspot.com/11365044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165848 0039d316-1c4b-4281-b951-d872f2087c98

3 files changed, 49 insertions, 7 deletions

diff --git a/build/android/buildbot/bb_fyi_builder.sh b/build/android/buildbot/bb_fyi_builder.sh
index 83c44fe..bf3d641 100755
--- a/build/android/buildbot/bb_fyi_builder.sh
+++ b/build/android/buildbot/bb_fyi_builder.sh
@@ -14,4 +14,6 @@ bb_baseline_setup "$BB_SRC_ROOT" "$@"
 bb_check_webview_licenses
 bb_compile
 bb_compile_experimental
+bb_run_findbugs_diff
+bb_run_findbugs_plugin_tests
 bb_zip_build
diff --git a/build/android/buildbot/buildbot_functions.sh b/build/android/buildbot/buildbot_functions.sh
index 9090b98..7835b46 100755
--- a/build/android/buildbot/buildbot_functions.sh
+++ b/build/android/buildbot/buildbot_functions.sh
@@ -217,6 +217,18 @@ echo '@@@BUILD_STEP experimental_unit_tests@@@'
 
 }
 
+# Run findbugs.
+function bb_run_findbugs_diff {
+  echo "@@@BUILD_STEP findbugs_diff@@@"
+  build/android/findbugs_diff.py
+}
+
+# Run findbugs plugin tests.
+function bb_run_findbugs_plugin_tests {
+  echo "@@@BUILD_STEP findbugs_plugin_tests@@@"
+  tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py
+}
+
 # Run a buildbot step and handle failure.
 function bb_run_step {
   (
diff --git a/build/android/findbugs_filter/findbugs_known_bugs.txt b/build/android/findbugs_filter/findbugs_known_bugs.txt
index daff462..f9ca178 100644
--- a/build/android/findbugs_filter/findbugs_known_bugs.txt
+++ b/build/android/findbugs_filter/findbugs_known_bugs.txt
@@ -1,8 +1,10 @@
 H B ES: Comparison of String parameter using == or != in org.chromium.android_webview.test.AwSettingsTest$AwSettingsUserAgentStringTestHelper.doEnsureSettingHasValue(String)   At AwSettingsTest.java
 H B Nm: The class name org.chromium.content.browser.test.util.TouchUtils shadows the simple name of the superclass android.test.TouchUtils  At TouchUtils.java
 H C EC: Using pointer equality to compare a JavaBridgeCoercionTest$CustomType with a JavaBridgeCoercionTest$CustomType2 in org.chromium.content.browser.JavaBridgeCoercionTest.testPassJavaObject()  At JavaBridgeCoercionTest.java
+H D RCN: Redundant nullcheck of org.chromium.content.browser.SandboxedProcessConnection.mConnectionParams, which is known to be non-null in org.chromium.content.browser.SandboxedProcessConnection.doConnectionSetup()  Redundant null check at SandboxedProcessConnection.java
 H D ST: Write to static field org.chromium.android_webview.test.util.TestWebServer.sInstance from instance method org.chromium.android_webview.test.util.TestWebServer.shutdown()  At TestWebServer.java
 H D ST: Write to static field org.chromium.content.app.SandboxedProcessService.sContext from instance method org.chromium.content.app.SandboxedProcessService.onCreate()  At SandboxedProcessService.java
+H M DL: Synchronization on Boolean in org.chromium.content.app.LibraryLoader.loadNow()  At LibraryLoader.java
 H V MS: org.chromium.android_webview.test.AndroidWebViewTestBase.WAIT_TIMEOUT_SECONDS isn't final but should be  At AndroidWebViewTestBase.java
 H V MS: org.chromium.android_webview.test.LoadDataWithBaseUrlTest.WAIT_TIMEOUT_SECONDS isn't final but should be  At LoadDataWithBaseUrlTest.java
 H V MS: org.chromium.content.app.AppResource.ARRAY_OFFICIAL_COMMAND_LINE isn't final but should be  In AppResource.java
@@ -40,14 +42,15 @@ H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_DONT_RELOAD_
 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_LEAVE_THIS_PAGE isn't final but should be  In AppResource.java
 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_RELOAD_THIS_PAGE isn't final but should be  In AppResource.java
 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_STAY_ON_THIS_PAGE isn't final but should be  In AppResource.java
-H V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_LOADING_VIDEO isn't final but should be  In AppResource.java
 H V MS: org.chromium.content.app.AppResource.STRING_MONTH_PICKER_DIALOG_TITLE isn't final but should be  In AppResource.java
 H V MS: org.chromium.content.browser.ContentViewTestBase.WAIT_TIMEOUT_SECONDS isn't final but should be  At ContentViewTestBase.java
 H V MS: org.chromium.content.browser.test.util.CallbackHelper.WAIT_TIMEOUT_SECONDS isn't final but should be  At CallbackHelper.java
 H V MS: org.chromium.content.browser.test.util.HistoryUtils.WAIT_TIMEOUT_SECONDS isn't final but should be  At HistoryUtils.java
 M B FS: Format string should use %n rather than \n in org.chromium.android_webview.test.AwSettingsTest.testUserAgentStringDefault()  At AwSettingsTest.java
 M B Nm: The class name org.chromium.android_webview.test.R$attr doesn't start with an upper case letter  At R.java
+M B Nm: The class name org.chromium.android_webview.test.R$drawable doesn't start with an upper case letter  At R.java
 M B Nm: The class name org.chromium.android_webview.test.R$raw doesn't start with an upper case letter  At R.java
+M B Nm: The class name org.chromium.android_webview.test.R$string doesn't start with an upper case letter  At R.java
 M B Nm: The class name org.chromium.chrome.testshell.Manifest$permission doesn't start with an upper case letter  At Manifest.java
 M B Nm: The class name org.chromium.chrome.testshell.R$attr doesn't start with an upper case letter  At R.java
 M B Nm: The class name org.chromium.chrome.testshell.R$dimen doesn't start with an upper case letter  At R.java
@@ -77,14 +80,34 @@ M B Nm: The class name org.chromium.content_shell.tests.R$string doesn't start w
 M B Nm: The class name org.chromium.native_test.R$attr doesn't start with an upper case letter  At R.java
 M B Nm: The class name org.chromium.native_test.R$string doesn't start with an upper case letter  At R.java
 M B Nm: The method name org.chromium.base.test.util.ScalableTimeout.ScaleTimeout(long) doesn't start with a lower case letter  At ScalableTimeout.java
+M B Nm: The method name org.chromium.content.browser.ContentViewCore.UpdateVSync(long, long) doesn't start with a lower case letter  At ContentViewCore.java
 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromium.android_webview.test.ArchiveTest.doArchiveTest(AwContents, String, boolean, String)  At ArchiveTest.java
 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromium.android_webview.test.ArchiveTest.testAutoBadPath()  At ArchiveTest.java
 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromium.android_webview.test.ArchiveTest.testExplicitBadPath()  At ArchiveTest.java
 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromium.android_webview.test.ArchiveTest.testExplicitGoodPath()  At ArchiveTest.java
-M B RV: exceptional return value of java.io.File.delete() ignored in org.chromium.android_webview.test.LoadDataWithBaseUrlTest.testLoadDataWithBaseUrlAccessingFile()  At LoadDataWithBaseUrlTest.java
 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromium.base.test.util.TestFileUtil.deleteFile(String)  At TestFileUtil.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At HttpAuthDatabase.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeArrayCoercionTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeArrayTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeBasicsTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeChildFrameTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeCoercionTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeFieldsTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeReturnValuesTest.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At JavaBridgeTestBase.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At PerfTraceEvent.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At SandboxedProcessConnection.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At SandboxedProcessLauncher.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At SimpleSynchronizedMethod.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At SimpleSynchronizedStaticMethod.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At TraceEvent.java
+M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope.  At X509Util.java
+M C CST: Shouldn't use synchronized(this), please narrow down the synchronization scope.  At HttpAuthDatabase.java
+M C CST: Shouldn't use synchronized(this), please narrow down the synchronization scope.  At SimpleSynchronizedThis.java
 M C IJU: TestCase org.chromium.android_webview.test.AndroidWebViewTestBase defines setUp that doesn't call super.setUp()  At AndroidWebViewTestBase.java
 M C IJU: TestCase org.chromium.android_webview.test.ArchiveTest defines setUp that doesn't call super.setUp()  At ArchiveTest.java
+M C IJU: TestCase org.chromium.android_webview.test.HttpAuthDatabaseTest defines setUp that doesn't call super.setUp()  At HttpAuthDatabaseTest.java
+M C IJU: TestCase org.chromium.android_webview.test.HttpAuthDatabaseTest defines tearDown that doesn't call super.tearDown()  At HttpAuthDatabaseTest.java
 M C IJU: TestCase org.chromium.chrome.testshell.ProviderBookmarkNodeTest defines setUp that doesn't call super.setUp()  At ProviderBookmarkNodeTest.java
 M C UMAC: Uncallable method org.chromium.content.browser.JavaBridgeBasicsTest$10.method() defined in anonymous class  At JavaBridgeBasicsTest.java
 M C UMAC: Uncallable method org.chromium.content.browser.JavaBridgeBasicsTest$11.method() defined in anonymous class  At JavaBridgeBasicsTest.java
@@ -120,10 +143,9 @@ M D DLS: Dead store to testUrl in org.chromium.android_webview.test.ClientOnPage
 M D DLS: Dead store to time in org.chromium.android_webview.test.util.TestWebServer.setDateHeaders(HttpResponse)  At TestWebServer.java
 M D DMI: Hard coded reference to an absolute pathname in org.chromium.android_webview.test.ArchiveTest.testAutoBadPath()  At ArchiveTest.java
 M D DMI: Hard coded reference to an absolute pathname in org.chromium.android_webview.test.ArchiveTest.testExplicitBadPath()  At ArchiveTest.java
+M D ICAST: Result of integer multiplication cast to long in org.chromium.android_webview.test.AwContentsClientShouldIgnoreNavigationTest.testShouldIgnoreNavigationNotCalledForPostNavigations()  At AwContentsClientShouldIgnoreNavigationTest.java
 M D ICAST: Result of integer multiplication cast to long in org.chromium.android_webview.test.AwSettingsTest.testBlockNetworkImagesBlocksNetworkImageAndReloadInPlace()  At AwSettingsTest.java
-M D ICAST: Result of integer multiplication cast to long in org.chromium.android_webview.test.AwShouldIgnoreNavigationTest.clickOnLinkUsingJs(AwContents, AwShouldIgnoreNavigationTest$TestAwContentsClient)  At AwShouldIgnoreNavigationTest.java
 M D ICAST: integral division result cast to double or float in org.chromium.content.browser.HandleView.setOrientation(int)  At HandleView.java
-M D RCN: Redundant nullcheck of org.chromium.content.browser.SandboxedProcessConnection.mConnectionParams, which is known to be non-null in org.chromium.content.browser.SandboxedProcessConnection.doConnectionSetup()  Redundant null check at SandboxedProcessConnection.java
 M D REC: Exception is caught when Exception is not thrown in org.chromium.content.browser.test.util.UiUtils.findParentViewForIdAcrossActivities(int)  At UiUtils.java
 M D SF: Switch statement found in org.chromium.chrome.browser.ChromeBrowserProvider.insert(Uri, ContentValues) where one case falls through to the next case  At ChromeBrowserProvider.java
 M D SF: Switch statement found in org.chromium.chrome.browser.database.SQLiteCursor.fillWindow(int, CursorWindow) where default case is missing  At SQLiteCursor.java
@@ -144,7 +166,6 @@ M D UrF: Unread public/protected field: org.chromium.content.browser.JavaBridgeF
 M D UrF: Unread public/protected field: org.chromium.content.browser.JavaBridgeFieldsTest$TestObject.shortField  At JavaBridgeFieldsTest.java
 M D UrF: Unread public/protected field: org.chromium.content.browser.JavaBridgeFieldsTest$TestObject.stringField  At JavaBridgeFieldsTest.java
 M D UuF: Unused public or protected field: org.chromium.content.browser.JavaBridgeBasicsTest$19.field  In JavaBridgeBasicsTest.java
-M M IS: Inconsistent synchronization of org.chromium.chrome.browser.ChromeBrowserProvider.mUriMatcher; locked 87% of time  Unsynchronized access at ChromeBrowserProvider.java
 M M IS: Inconsistent synchronization of org.chromium.content.browser.SandboxedProcessConnection.mPID; locked 66% of time  Unsynchronized access at SandboxedProcessConnection.java
 M M IS: Inconsistent synchronization of org.chromium.content.browser.SandboxedProcessConnection.mService; locked 55% of time  Unsynchronized access at SandboxedProcessConnection.java
 M M IS: Inconsistent synchronization of org.chromium.content.browser.SandboxedProcessConnection.mServiceConnectComplete; locked 60% of time  Unsynchronized access at SandboxedProcessConnection.java
@@ -157,7 +178,6 @@ M M UG: org.chromium.content.browser.JavaBridgeReturnValuesTest$TestObject.getSt
 M M UW: Unconditional wait in org.chromium.content.browser.VSyncMonitorTest.testVSyncPeriod()  At VSyncMonitorTest.java
 M M Wa: Wait not in loop in org.chromium.content.browser.VSyncMonitorTest.testVSyncPeriod()  At VSyncMonitorTest.java
 M P SIC: Should org.chromium.android_webview.test.AwSettingsTest$ViewPair be a _static_ inner class?  At AwSettingsTest.java
-M P SIC: Should org.chromium.android_webview.test.AwShouldIgnoreNavigationTest$TestAwContentsClient$ShouldIgnoreNavigationHelper be a _static_ inner class?  At AwShouldIgnoreNavigationTest.java
 M P SIC: Should org.chromium.android_webview.test.TestAwContentsClient$AddMessageToConsoleHelper be a _static_ inner class?  At TestAwContentsClient.java
 M P SIC: Should org.chromium.android_webview.test.TestContentProvider$ProviderStateCursor be a _static_ inner class?  At TestContentProvider.java
 M P SIC: Should org.chromium.content.browser.ContentVideoView$ProgressView be a _static_ inner class?  At ContentVideoView.java
@@ -169,11 +189,13 @@ M P SIC: Should org.chromium.content.browser.PopupZoomerTest$CustomCanvasPopupZo
 M P SIC: Should org.chromium.content.browser.VSyncMonitorTest$TestTimeSource be a _static_ inner class?  At VSyncMonitorTest.java
 M P SIC: Should org.chromium.content.browser.VSyncMonitorTest$TestView be a _static_ inner class?  At VSyncMonitorTest.java
 M P SIC: Should org.chromium.content.browser.VSyncMonitorTest$VSyncDataCollector be a _static_ inner class?  At VSyncMonitorTest.java
+M P SS: Unread field: org.chromium.android_webview.test.AwSettingsTest$AwSettingsTextZoomTestHelper.mInitialTextZoom; should this field be static?  At AwSettingsTest.java
 M P SS: Unread field: org.chromium.android_webview.test.util.ImagePageGenerator.IMAGE_PREFIX; should this field be static?  At ImagePageGenerator.java
 M P SS: Unread field: org.chromium.android_webview.test.util.ImagePageGenerator.IMAGE_SUFFIX; should this field be static?  At ImagePageGenerator.java
 M P SS: Unread field: org.chromium.native_test.ChromeNativeTestActivity.EXTRA_RUN_IN_SUB_THREAD; should this field be static?  At ChromeNativeTestActivity.java
 M P SS: Unread field: org.chromium.native_test.ChromeNativeTestActivity.TAG; should this field be static?  At ChromeNativeTestActivity.java
 M P UPM: Private method org.chromium.chrome.browser.component.web_contents_delegate_android.WebContentsDelegateAndroid.onLoadProgressChanged(double) is never called  At WebContentsDelegateAndroid.java
+M P UrF: Unread field: org.chromium.chrome.browser.GoogleLocationSettingsHelperStub.mApplicationContext  At GoogleLocationSettingsHelperStub.java
 M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastFling2  At ContentViewGestureHandlerTest.java
 M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastScroll1  At ContentViewGestureHandlerTest.java
 M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastScroll2  At ContentViewGestureHandlerTest.java
@@ -189,15 +211,22 @@ M V EI2: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.setThumb
 M V EI2: org.chromium.content.browser.LoadUrlParams.setPostData(byte[]) may expose internal representation by storing an externally mutable object into LoadUrlParams.mPostData  At LoadUrlParams.java
 M V EI: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.favicon() may expose internal representation by returning ChromeBrowserProvider$BookmarkNode.mFavicon  At ChromeBrowserProvider.java
 M V EI: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.thumbnail() may expose internal representation by returning ChromeBrowserProvider$BookmarkNode.mThumbnail  At ChromeBrowserProvider.java
+M V MS: org.chromium.android_webview.AwResource.RAW_LOAD_ERROR isn't final and can't be protected from malicious code   In AwResource.java
+M V MS: org.chromium.android_webview.AwResource.RAW_NO_DOMAIN isn't final and can't be protected from malicious code   In AwResource.java
+M V MS: org.chromium.android_webview.AwResource.STRING_DEFAULT_TEXT_ENCODING isn't final and can't be protected from malicious code   In AwResource.java
 M V MS: org.chromium.content.app.AppResource.DIMENSION_LINK_PREVIEW_OVERLAY_RADIUS isn't final and can't be protected from malicious code   In AppResource.java
 M V MS: org.chromium.content.app.AppResource.DRAWABLE_ICON_ACTION_BAR_SHARE isn't final and can't be protected from malicious code   In AppResource.java
 M V MS: org.chromium.content.app.AppResource.DRAWABLE_ICON_ACTION_BAR_WEB_SEARCH isn't final and can't be protected from malicious code   In AppResource.java
 M V MS: org.chromium.content.app.AppResource.DRAWABLE_LINK_PREVIEW_POPUP_OVERLAY isn't final and can't be protected from malicious code   In AppResource.java
+M V MS: org.chromium.content.app.AppResource.ID_AUTOFILL_LABEL isn't final and can't be protected from malicious code   In AppResource.java
+M V MS: org.chromium.content.app.AppResource.ID_AUTOFILL_NAME isn't final and can't be protected from malicious code   In AppResource.java
+M V MS: org.chromium.content.app.AppResource.LAYOUT_AUTOFILL_TEXT isn't final and can't be protected from malicious code   In AppResource.java
 M V MS: org.chromium.content.app.AppResource.STRING_ACTION_BAR_SHARE isn't final and can't be protected from malicious code   In AppResource.java
 M V MS: org.chromium.content.app.AppResource.STRING_ACTION_BAR_WEB_SEARCH isn't final and can't be protected from malicious code   In AppResource.java
 M V MS: org.chromium.content.app.AppResource.STRING_CONTENT_VIEW_CONTENT_DESCRIPTION isn't final and can't be protected from malicious code   In AppResource.java
 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_ERROR_BUTTON isn't final and can't be protected from malicious code   In AppResource.java
 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_ERROR_TITLE isn't final and can't be protected from malicious code   In AppResource.java
+M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_LOADING_VIDEO isn't final and can't be protected from malicious code   In AppResource.java
 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_MESSAGE_PLAYBACK_ERROR isn't final and can't be protected from malicious code   In AppResource.java
 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_MESSAGE_UNKNOWN_ERROR isn't final and can't be protected from malicious code   In AppResource.java
 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_BROWSER_INITIATED_HTTP_POST should be package protected  In LoadUrlParams.java
@@ -205,4 +234,3 @@ M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DATA isn't final an
 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DEFAULT should be package protected  In LoadUrlParams.java
 M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_INHERIT should be package protected  In LoadUrlParams.java
 M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE should be package protected  In LoadUrlParams.java
-M X OBL: org.chromium.android_webview.test.LoadDataWithBaseUrlTest.testLoadDataWithBaseUrlAccessingFile() may fail to clean up java.io.OutputStream  Obligation to clean up resource created at LoadDataWithBaseUrlTest.java:[line 290] is not discharged