summaryrefslogtreecommitdiffstats
path: root/build
diff options
context:
space:
mode:
authorjbudorick <jbudorick@chromium.org>2014-10-02 16:33:22 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-02 23:35:47 +0000
commitfc3ea0426cee341318cdc8d3f9ebb729e1dd64c5 (patch)
tree5b86567e57a2d14b0b0dccdf338e1fced05dd339 /build
parent7aa4a8aa24612b36878415c27c7bb22461637f75 (diff)
downloadchromium_src-fc3ea0426cee341318cdc8d3f9ebb729e1dd64c5.zip
chromium_src-fc3ea0426cee341318cdc8d3f9ebb729e1dd64c5.tar.gz
chromium_src-fc3ea0426cee341318cdc8d3f9ebb729e1dd64c5.tar.bz2
Revert of [Android] Don't push deps when listing gtests. (patchset #1 id:1 of https://codereview.chromium.org/560133002/)
Reason for revert: While we do want to only attempt to push once, this isn't the right way to do it. We should push _before_ attempting to list the tests, then be done with it. Also, this breaks https://codereview.chromium.org/537063002/ Original issue's description: > [Android] Don't push deps when listing gtests. > > PushDataDeps takes a long time even when all files are on the device > because calculating the digests of all the files takes _much_ longer > on a device than it does on a host. > > Skipping the push step during test listing -- where the data deps are > unnecessary -- means that we don't try to push files twice in each > gtest run, so we skip all of the device-side MD5 calculations that > would happen in the second run. > > BUG=400440 > > Committed: https://crrev.com/5c10479a0c3572cd41062b453c3e85527b5cfbad > Cr-Commit-Position: refs/heads/master@{#294667} TBR=starodub@chromium.org,cjhopman@chromium.org,klundberg@chromium.org NOTREECHECKS=true NOTRY=true BUG=400440 Review URL: https://codereview.chromium.org/627553002 Cr-Commit-Position: refs/heads/master@{#297948}
Diffstat (limited to 'build')
-rw-r--r--build/android/pylib/gtest/setup.py5
1 files changed, 0 insertions, 5 deletions
diff --git a/build/android/pylib/gtest/setup.py b/build/android/pylib/gtest/setup.py
index 0dfea6d..1e52d3b 100644
--- a/build/android/pylib/gtest/setup.py
+++ b/build/android/pylib/gtest/setup.py
@@ -218,11 +218,6 @@ def _GetTests(test_options, test_package, devices):
"""
def TestListerRunnerFactory(device, _shard_index):
class TestListerRunner(test_runner.TestRunner):
- #override
- def PushDataDeps(self):
- pass
-
- #override
def RunTest(self, _test):
result = base_test_result.BaseTestResult(
'gtest_list_tests', base_test_result.ResultType.PASS)