diff options
| author | dalecurtis <dalecurtis@chromium.org> | 2015-10-22 18:07:02 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-23 01:08:00 +0000 |
| commit | c2574ed2dede52cbf0353a3aca99d96cf0794571 (patch) | |
| tree | e43b61b88914a189740442daaa59b0743c513ad2 /build_overrides | |
| parent | 0232219b2a00e7366adffd716e61d53a3c842f23 (diff) | |
| download | chromium_src-c2574ed2dede52cbf0353a3aca99d96cf0794571.zip chromium_src-c2574ed2dede52cbf0353a3aca99d96cf0794571.tar.gz chromium_src-c2574ed2dede52cbf0353a3aca99d96cf0794571.tar.bz2 | |
Revert of Switch Chrome Android using v8 arch specific external data name (patchset #5 id:80001 of https://codereview.chromium.org/1400953002/ )
Reason for revert:
Looks to have broken various Android Mojo tests:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=31621
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=31622
Original issue's description:
> Switch Chrome Android using v8 arch specific external data name
>
> For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used.
> For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used.
>
> This patch also removed the existing v8 startup data in
> destination directory by using copy_ex to remove directory
> first.
>
> BUG=540788
>
> Committed: https://crrev.com/979b03a19f63b1cbe02fa3df99707c3f93f7c9cf
> Cr-Commit-Position: refs/heads/master@{#355680}
TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org,jam@chromium.org,michaelbai@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=540788
Review URL: https://codereview.chromium.org/1419673008
Cr-Commit-Position: refs/heads/master@{#355697}
Diffstat (limited to 'build_overrides')
| -rw-r--r-- | build_overrides/v8.gni | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/build_overrides/v8.gni b/build_overrides/v8.gni index 02bb900..ee1b666 100644 --- a/build_overrides/v8.gni +++ b/build_overrides/v8.gni @@ -22,21 +22,3 @@ v8_use_external_startup_data = !(is_win || is_ios) v8_extra_library_files = [] v8_experimental_extra_library_files = [ "../third_party/WebKit/Source/core/streams/ByteLengthQueuingStrategy.js" ] - -if (is_android) { - v8_external_startup_data_renaming_sources = [ - "$root_build_dir/natives_blob.bin", - "$root_build_dir/snapshot_blob.bin", - ] - if (current_cpu == "arm" || current_cpu == "x86" || current_cpu == "mipsel") { - v8_external_startup_data_renaming_destinations = [ - "natives_blob_32.bin", - "snapshot_blob_32.bin", - ] - } else { - v8_external_startup_data_renaming_destinations = [ - "natives_blob_64.bin", - "snapshot_blob_64.bin", - ] - } -} |