summaryrefslogtreecommitdiffstats
path: root/build_overrides
diff options
context:
space:
mode:
authorsammc <sammc@chromium.org>2015-11-02 19:30:57 -0800
committerCommit bot <commit-bot@chromium.org>2015-11-03 03:31:49 +0000
commitfdd09962365511096c8f8c4ec388254325aa90e6 (patch)
tree770cc1cbd7088f3c9a22aa987f971d8f095cfe40 /build_overrides
parent497461fa4b777712656dc6b3ba5b133b36e00693 (diff)
downloadchromium_src-fdd09962365511096c8f8c4ec388254325aa90e6.zip
chromium_src-fdd09962365511096c8f8c4ec388254325aa90e6.tar.gz
chromium_src-fdd09962365511096c8f8c4ec388254325aa90e6.tar.bz2
Revert of Reland Reland Switch Chrome Android using v8 arch specific external data name (patchset #9 id:180001 of https://codereview.chromium.org/1422793004/ )
Reason for revert: Looks like it caused Android GN net_unittests to crash: https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/31886/steps/net_unittests/logs/stdio; suspect it's crashing a ProxyResolverV8 test. Original issue's description: > Reland Reland Switch Chrome Android using v8 arch specific external data name > > This patch also fix package_resource.py issue that asset's > renaming didn't trigger the packaging. > > origin patch > https://codereview.chromium.org/1417753004/ > > Switch Chrome Android using v8 arch specific external data name > > For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. > For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. > > This patch also removed the existing v8 startup data in > destination directory by using copy_ex to remove directory > first. > > BUG=540788,547235 > > TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org > > Committed: https://crrev.com/02d6496adfb377afc0708e53cd0c8118c0591f99 > Cr-Commit-Position: refs/heads/master@{#357480} TBR=jbudorick@chromium.org,miguelg@chromium.org,michaelbai@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540788,547235 Review URL: https://codereview.chromium.org/1432553003 Cr-Commit-Position: refs/heads/master@{#357523}
Diffstat (limited to 'build_overrides')
-rw-r--r--build_overrides/v8.gni18
1 files changed, 0 insertions, 18 deletions
diff --git a/build_overrides/v8.gni b/build_overrides/v8.gni
index f1f27de..ee1b666 100644
--- a/build_overrides/v8.gni
+++ b/build_overrides/v8.gni
@@ -22,21 +22,3 @@ v8_use_external_startup_data = !(is_win || is_ios)
v8_extra_library_files = []
v8_experimental_extra_library_files =
[ "../third_party/WebKit/Source/core/streams/ByteLengthQueuingStrategy.js" ]
-
-if (is_android) {
- v8_external_startup_data_renaming_sources = [
- "$root_out_dir/natives_blob.bin",
- "$root_out_dir/snapshot_blob.bin",
- ]
- if (current_cpu == "arm" || current_cpu == "x86" || current_cpu == "mipsel") {
- v8_external_startup_data_renaming_destinations = [
- "natives_blob_32.bin",
- "snapshot_blob_32.bin",
- ]
- } else {
- v8_external_startup_data_renaming_destinations = [
- "natives_blob_64.bin",
- "snapshot_blob_64.bin",
- ]
- }
-}