diff options
| author | dcheng <dcheng@chromium.org> | 2014-10-21 13:29:55 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-21 20:30:24 +0000 |
| commit | 19b6b65f39712670a4bf8289cdeb4992c62ef27c (patch) | |
| tree | ad248c4106ec5a53f1dd60f59809da140d9b1a48 /cc/PRESUBMIT.py | |
| parent | ccbfe27c8d2b4fcb7ddc98064ec6aa5820fcfe9a (diff) | |
| download | chromium_src-19b6b65f39712670a4bf8289cdeb4992c62ef27c.zip chromium_src-19b6b65f39712670a4bf8289cdeb4992c62ef27c.tar.gz chromium_src-19b6b65f39712670a4bf8289cdeb4992c62ef27c.tar.bz2 | |
Clean up final uses of scoped_ptr<T>::PassAs() and remove it.
This helper to upcast in return statements is no longer needed.
BUG=423621
Review URL: https://codereview.chromium.org/663243003
Cr-Commit-Position: refs/heads/master@{#300548}
Diffstat (limited to 'cc/PRESUBMIT.py')
| -rw-r--r-- | cc/PRESUBMIT.py | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py index 1aa48f3..0393161 100644 --- a/cc/PRESUBMIT.py +++ b/cc/PRESUBMIT.py @@ -191,12 +191,6 @@ def CheckScopedPtr(input_api, output_api, errors.append(output_api.PresubmitError( '%s:%d uses scoped_ptr<T>(). Use nullptr instead.' % (f.LocalPath(), line_number))) - # Disallow: - # foo.PassAs<T>(); - if re.search(r'\bPassAs<.*?>\(\)', line): - errors.append(output_api.PresubmitError( - '%s:%d uses PassAs<T>(). Use Pass() instead.' % - (f.LocalPath(), line_number))) return errors def FindUnquotedQuote(contents, pos): |