summaryrefslogtreecommitdiffstats
path: root/cc/PRESUBMIT.py
diff options
context:
space:
mode:
authormostynb <mostynb@opera.com>2014-10-22 08:10:05 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-22 15:11:02 +0000
commita924ebe97ccde57415f5c7fd94109663d2d1d6a2 (patch)
treebbc1739f74338d248e18bb46611aef375832bc8f /cc/PRESUBMIT.py
parent826d0a0cc35014f243399625b53929af9a3773db (diff)
downloadchromium_src-a924ebe97ccde57415f5c7fd94109663d2d1d6a2.zip
chromium_src-a924ebe97ccde57415f5c7fd94109663d2d1d6a2.tar.gz
chromium_src-a924ebe97ccde57415f5c7fd94109663d2d1d6a2.tar.bz2
remove OVERRIDE/FINAL presubmit checks now the macros are gone
BUG=417463 Review URL: https://codereview.chromium.org/670073003 Cr-Commit-Position: refs/heads/master@{#300681}
Diffstat (limited to 'cc/PRESUBMIT.py')
-rw-r--r--cc/PRESUBMIT.py37
1 files changed, 0 insertions, 37 deletions
diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py
index 0393161..46c3a54 100644
--- a/cc/PRESUBMIT.py
+++ b/cc/PRESUBMIT.py
@@ -326,42 +326,6 @@ def CheckForUseOfWrongClock(input_api,
else:
return []
-def CheckOverrideFinal(input_api, output_api,
- whitelist=CC_SOURCE_FILES, blacklist=None):
- """Make sure new lines of code don't use the OVERRIDE or FINAL macros."""
-
- # TODO(mostynb): remove this check once the macros are removed
- # from base/compiler_specific.h.
-
- errors = []
-
- source_file_filter = lambda x: input_api.FilterSourceFile(
- x, white_list=CC_SOURCE_FILES, black_list=None)
-
- override_files = []
- final_files = []
-
- for f in input_api.AffectedSourceFiles(source_file_filter):
- contents = input_api.ReadFile(f, 'rb')
-
- # "override" and "final" should be used instead of OVERRIDE/FINAL now.
- if re.search(r"\bOVERRIDE\b", contents):
- override_files.append(f.LocalPath())
-
- if re.search(r"\bFINAL\b", contents):
- final_files.append(f.LocalPath())
-
- if override_files:
- return [output_api.PresubmitError(
- 'These files use OVERRIDE instead of using override:',
- items=override_files)]
- if final_files:
- return [output_api.PresubmitError(
- 'These files use FINAL instead of using final:',
- items=final_files)]
-
- return []
-
def CheckChangeOnUpload(input_api, output_api):
results = []
results += CheckAsserts(input_api, output_api)
@@ -374,7 +338,6 @@ def CheckChangeOnUpload(input_api, output_api):
results += CheckNamespace(input_api, output_api)
results += CheckForUseOfWrongClock(input_api, output_api)
results += FindUselessIfdefs(input_api, output_api)
- results += CheckOverrideFinal(input_api, output_api)
results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
return results