diff options
| author | enne@chromium.org <enne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-06 05:45:11 +0000 |
|---|---|---|
| committer | enne@chromium.org <enne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-06 05:45:11 +0000 |
| commit | c9ca44de8bf0762d802ccbb9336321145aadc8ee (patch) | |
| tree | c62813d5ceed0a61dff3092a4e7c6d6155e7ca6c /cc/PRESUBMIT.py | |
| parent | 235c7b4cda7a94c4834593d3242da5ff34650242 (diff) | |
| download | chromium_src-c9ca44de8bf0762d802ccbb9336321145aadc8ee.zip chromium_src-c9ca44de8bf0762d802ccbb9336321145aadc8ee.tar.gz chromium_src-c9ca44de8bf0762d802ccbb9336321145aadc8ee.tar.bz2 | |
cc: Ban (f)printf via presubmit.py
I see these accidentally leak into codereview sometimes, and it'd be nice to
just have it automatically be prevented.
NOTRY=true
R=danakj@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11794017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175296 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/PRESUBMIT.py')
| -rw-r--r-- | cc/PRESUBMIT.py | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py index 1c3613a..319d3b5 100644 --- a/cc/PRESUBMIT.py +++ b/cc/PRESUBMIT.py @@ -11,6 +11,7 @@ details on the presubmit API built into gcl. import re CC_SOURCE_FILES=(r'^cc/.*\.(cc|h)$',) +CC_PERF_TEST =(r'^.*_perftest.*\.(cc|h)$',) def CheckAsserts(input_api, output_api, white_list=CC_SOURCE_FILES, black_list=None): black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST) @@ -42,24 +43,31 @@ def CheckSpamLogging(input_api, output_api, white_list=CC_SOURCE_FILES, black_li black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST) source_file_filter = lambda x: input_api.FilterSourceFile(x, white_list, black_list) - bad_files = [] + log_info = [] + printf = [] for f in input_api.AffectedSourceFiles(source_file_filter): contents = input_api.ReadFile(f, 'rb') if re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents): - bad_files.append(f.LocalPath()) + log_info.append(f.LocalPath()) + if re.search(r"\bf?printf\(", contents): + printf.append(f.LocalPath()) - if bad_files: + if log_info: return [output_api.PresubmitError( 'These files spam the console log with LOG(INFO):', - items=bad_files)] + items=log_info)] + if printf: + return [output_api.PresubmitError( + 'These files spam the console log with printf/fprintf:', + items=printf)] return [] def CheckChangeOnUpload(input_api, output_api): results = [] results += CheckAsserts(input_api, output_api) - results += CheckSpamLogging(input_api, output_api) + results += CheckSpamLogging(input_api, output_api, black_list=CC_PERF_TEST) return results def GetPreferredTrySlaves(project, change): |