summaryrefslogtreecommitdiffstats
path: root/cc/cc_tests.gyp
diff options
context:
space:
mode:
authorgbillock@chromium.org <gbillock@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-29 18:12:51 +0000
committergbillock@chromium.org <gbillock@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-29 18:12:51 +0000
commite5bd68e150c9d2b46187d2d1a7d948f709760d34 (patch)
tree7873a45605fd045fb5c5e2f4b74ac31cda4d2ec4 /cc/cc_tests.gyp
parent23746ecba9f532c29fdc982b623074050242b986 (diff)
downloadchromium_src-e5bd68e150c9d2b46187d2d1a7d948f709760d34.zip
chromium_src-e5bd68e150c9d2b46187d2d1a7d948f709760d34.tar.gz
chromium_src-e5bd68e150c9d2b46187d2d1a7d948f709760d34.tar.bz2
Revert 191376 "Propegate setting autohide behaviour to prefs"
> Propegate setting autohide behaviour to prefs > > When the ShelfLayoutManager changes the autohide behaviour this needs to be > propegated to the ChromeLauncherController otherwise when other parts of the > system query the autohide status they can end up with an incorrect value. This > resolves most of the outstanding issues with the "Autohide Launcher" checkbox in > the context menu. > > These is still one issue, specifically if you set autohide off, swipe the > launcher off the screen and then make it reappear, via either swiping or mouse > over. The checkbox will not be checked in this case, but the moment you touch or > click off of the launcher it will hide. After hiding the checkbox will be set as > expected, thus partially resolving that fact that you had to turn on autohide > before you could turn it off. This issue due to the fact that the > ShelfLayoutManager is actually turning off autohide, but setting a handler to > watch for future events and when you interact outside of the launcher setting > autohide on again. Resolving this is outside the scope of this CL/bug since it > either requires changing our UI behjaviour or plumbing information about being > in this state to the LaunchContextMenu, both of which would be unlikely to be > backported to 27. > > BUG=chromium:173295 > TEST=Visually confirmed that the checkbox is repersenative of the state of > autohide or is only transistorially incorrect. > > Review URL: https://chromiumcodereview.appspot.com/12636012 TBR=rharrison@chromium.org Review URL: https://codereview.chromium.org/13322004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191399 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/cc_tests.gyp')
0 files changed, 0 insertions, 0 deletions