diff options
| author | chrishtr <chrishtr@chromium.org> | 2015-12-16 10:21:51 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-16 18:22:53 +0000 |
| commit | c1b7e81571d94d31560dc340d0b95d1ed8e95bf9 (patch) | |
| tree | c4e07cd6e5dfc85be185855f02e186b247e6cb79 /cc/debug | |
| parent | 36468e42069cf60fd93b869fa5b59d9089c959d0 (diff) | |
| download | chromium_src-c1b7e81571d94d31560dc340d0b95d1ed8e95bf9.zip chromium_src-c1b7e81571d94d31560dc340d0b95d1ed8e95bf9.tar.gz chromium_src-c1b7e81571d94d31560dc340d0b95d1ed8e95bf9.tar.bz2 | |
Adjust metrics in RasterizeAndRecordBenchmark to have the correct pixels_recorded.
Now that the benchmark records the entire PaintableRegion, rather than just the
visual rect, use that as the space for pixels_recorded.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1528603002
Cr-Commit-Position: refs/heads/master@{#365560}
Diffstat (limited to 'cc/debug')
| -rw-r--r-- | cc/debug/rasterize_and_record_benchmark.cc | 10 | ||||
| -rw-r--r-- | cc/debug/rasterize_and_record_benchmark.h | 3 |
2 files changed, 2 insertions, 11 deletions
diff --git a/cc/debug/rasterize_and_record_benchmark.cc b/cc/debug/rasterize_and_record_benchmark.cc index 5624fb1c..9f4e134 100644 --- a/cc/debug/rasterize_and_record_benchmark.cc +++ b/cc/debug/rasterize_and_record_benchmark.cc @@ -111,12 +111,6 @@ void RasterizeAndRecordBenchmark::RunOnLayer(PictureLayer* layer) { if (visible_layer_rect.IsEmpty()) return; - RunOnDisplayListLayer(layer, visible_layer_rect); -} - -void RasterizeAndRecordBenchmark::RunOnDisplayListLayer( - PictureLayer* layer, - const gfx::Rect& visible_layer_rect) { ContentLayerClient* painter = layer->client(); for (int mode_index = 0; @@ -182,8 +176,8 @@ void RasterizeAndRecordBenchmark::RunOnDisplayListLayer( if (mode_index == DisplayListRecordingSource::RECORD_NORMALLY) { record_results_.bytes_used += memory_used + painter->GetApproximateUnsharedMemoryUsage(); - record_results_.pixels_recorded += - visible_layer_rect.width() * visible_layer_rect.height(); + record_results_.pixels_recorded += painter->PaintableRegion().width() * + painter->PaintableRegion().height(); } record_results_.total_best_time[mode_index] += min_time; } diff --git a/cc/debug/rasterize_and_record_benchmark.h b/cc/debug/rasterize_and_record_benchmark.h index 1e69851..d96f087 100644 --- a/cc/debug/rasterize_and_record_benchmark.h +++ b/cc/debug/rasterize_and_record_benchmark.h @@ -39,9 +39,6 @@ class RasterizeAndRecordBenchmark : public MicroBenchmark { scoped_refptr<base::SingleThreadTaskRunner> origin_task_runner) override; private: - void RunOnDisplayListLayer(PictureLayer* layer, - const gfx::Rect& visible_layer_rect); - void RecordRasterResults(scoped_ptr<base::Value> results); struct RecordResults { |