diff options
author | sunxd <sunxd@chromium.org> | 2016-03-16 09:23:20 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-16 16:25:20 +0000 |
commit | c044b11a0cdf5bfc7c13c1b2dfb41b6b415e18f5 (patch) | |
tree | f3e3e7e3422326e4dae307d3f08dfbab7bc4a3c3 /cc/layers/layer_impl_unittest.cc | |
parent | b18dcbd20c61ba22fd430bbbf0066f738d480a66 (diff) | |
download | chromium_src-c044b11a0cdf5bfc7c13c1b2dfb41b6b415e18f5.zip chromium_src-c044b11a0cdf5bfc7c13c1b2dfb41b6b415e18f5.tar.gz chromium_src-c044b11a0cdf5bfc7c13c1b2dfb41b6b415e18f5.tar.bz2 |
Clean scroll logic in LayerTreeImpl:
* Move DidUpdateScrollOffset to LayerTreeImpl
* Make SyncedScrollOffset transparent to LayerImpl
BUG=568830
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1803643002
Cr-Commit-Position: refs/heads/master@{#381467}
Diffstat (limited to 'cc/layers/layer_impl_unittest.cc')
-rw-r--r-- | cc/layers/layer_impl_unittest.cc | 31 |
1 files changed, 17 insertions, 14 deletions
diff --git a/cc/layers/layer_impl_unittest.cc b/cc/layers/layer_impl_unittest.cc index 177866a..15d8e94 100644 --- a/cc/layers/layer_impl_unittest.cc +++ b/cc/layers/layer_impl_unittest.cc @@ -105,13 +105,11 @@ namespace { EXPECT_FALSE(host_impl.active_tree()->needs_update_draw_properties()); static gfx::Vector2dF ScrollDelta(LayerImpl* layer_impl) { - if (layer_impl->IsActive()) - return gfx::Vector2dF(layer_impl->synced_scroll_offset()->Delta().x(), - layer_impl->synced_scroll_offset()->Delta().y()); - else - return gfx::Vector2dF( - layer_impl->synced_scroll_offset()->PendingDelta().get().x(), - layer_impl->synced_scroll_offset()->PendingDelta().get().y()); + gfx::ScrollOffset delta = + layer_impl->layer_tree_impl() + ->property_trees() + ->scroll_tree.GetScrollOffsetDeltaForTesting(layer_impl->id()); + return gfx::Vector2dF(delta.x(), delta.y()); } TEST(LayerImplTest, VerifyLayerChangesAreTrackedProperly) { @@ -195,10 +193,11 @@ TEST(LayerImplTest, VerifyLayerChangesAreTrackedProperly) { EXECUTE_AND_VERIFY_SUBTREE_CHANGED(root->OnFilterAnimated(arbitrary_filters)); EXECUTE_AND_VERIFY_SUBTREE_CHANGED( root->OnFilterAnimated(FilterOperations())); - EXECUTE_AND_VERIFY_SUBTREE_CHANGED(root->ScrollBy(arbitrary_vector2d)); EXECUTE_AND_VERIFY_SUBTREE_CHANGED(root->OnOpacityAnimated(arbitrary_number)); EXECUTE_AND_VERIFY_SUBTREE_CHANGED( root->OnTransformAnimated(arbitrary_transform)); + EXECUTE_AND_VERIFY_SUBTREE_CHANGED(root->ScrollBy(arbitrary_vector2d); + root->SetNeedsPushProperties()); // SetBoundsDelta changes subtree only when masks_to_bounds is true and it // doesn't set needs_push_properties as it is always called on active tree. root->SetMasksToBounds(true); @@ -348,9 +347,13 @@ TEST(LayerImplTest, VerifyNeedsUpdateDrawProperties) { VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(layer->SetBounds(large_size)); VERIFY_NEEDS_UPDATE_DRAW_PROPERTIES(layer->ScrollBy(arbitrary_vector2d)); VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(layer->ScrollBy(gfx::Vector2d())); - VERIFY_NEEDS_UPDATE_DRAW_PROPERTIES(layer->DidUpdateScrollOffset()); - layer->SetCurrentScrollOffset(layer->synced_scroll_offset()->ActiveBase() + - gfx::ScrollOffset()); + VERIFY_NEEDS_UPDATE_DRAW_PROPERTIES( + layer->layer_tree_impl()->DidUpdateScrollOffset( + layer->id(), layer->transform_tree_index())); + layer->layer_tree_impl() + ->property_trees() + ->scroll_tree.SetScrollOffsetDeltaForTesting(layer->id(), + gfx::Vector2dF()); VERIFY_NEEDS_UPDATE_DRAW_PROPERTIES(layer->SetCurrentScrollOffset( gfx::ScrollOffset(arbitrary_vector2d.x(), arbitrary_vector2d.y()))); VERIFY_NO_NEEDS_UPDATE_DRAW_PROPERTIES(layer->SetCurrentScrollOffset( @@ -604,7 +607,7 @@ TEST_F(LayerImplScrollTest, ApplySentScrollsNoListener) { scroll_tree(layer())->UpdateScrollOffsetBaseForTesting(layer()->id(), scroll_offset); layer()->ScrollBy(sent_scroll_delta); - layer()->synced_scroll_offset()->PullDeltaForMainThread(); + scroll_tree(layer())->CollectScrollDeltasForTesting(); layer()->SetCurrentScrollOffset(scroll_offset + gfx::ScrollOffset(scroll_delta)); @@ -615,7 +618,7 @@ TEST_F(LayerImplScrollTest, ApplySentScrollsNoListener) { scroll_offset, scroll_tree(layer())->GetScrollOffsetBaseForTesting(layer()->id())); - layer()->synced_scroll_offset()->AbortCommit(); + scroll_tree(layer())->ApplySentScrollDeltasFromAbortedCommit(); EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, scroll_delta), layer()->CurrentScrollOffset()); @@ -651,7 +654,7 @@ TEST_F(LayerImplScrollTest, PushPropertiesToMirrorsCurrentScrollOffset) { EXPECT_VECTOR_EQ(gfx::Vector2dF(0, 0), unscrolled); EXPECT_VECTOR_EQ(gfx::Vector2dF(22, 23), layer()->CurrentScrollOffset()); - layer()->synced_scroll_offset()->PullDeltaForMainThread(); + scroll_tree(layer())->CollectScrollDeltasForTesting(); scoped_ptr<LayerImpl> pending_layer = LayerImpl::Create(host_impl().sync_tree(), layer()->id()); |