summaryrefslogtreecommitdiffstats
path: root/cc/output/software_output_device.h
diff options
context:
space:
mode:
authorprashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-10 20:05:06 +0000
committerprashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-10 20:05:06 +0000
commit0023fc78d056556b353ee17f03760bec8c1fee49 (patch)
tree009367358a1c44b08f3142f63b087d936206ba44 /cc/output/software_output_device.h
parent37df32bd517577ac6ad20c6d76b236265caeacaf (diff)
downloadchromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.zip
chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.gz
chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.bz2
Pass gfx::Rect and gfx::RectF by const ref.
Avoid unneccessary copy of structures gfx::Rect & gfx::RectF by passing them by const ref rather than value. Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters. Pass by value creates unneccessary overhead which should be avoided. BUG=159273 Review URL: https://codereview.chromium.org/93663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/output/software_output_device.h')
-rw-r--r--cc/output/software_output_device.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/cc/output/software_output_device.h b/cc/output/software_output_device.h
index 4ecf1fe..e203902 100644
--- a/cc/output/software_output_device.h
+++ b/cc/output/software_output_device.h
@@ -42,7 +42,7 @@ class CC_EXPORT SoftwareOutputDevice {
// SkCanvas. The |SoftwareOutputDevice| implementation needs to provide a
// valid SkCanvas of at least size |damage_rect|. This class retains ownership
// of the SkCanvas.
- virtual SkCanvas* BeginPaint(gfx::Rect damage_rect);
+ virtual SkCanvas* BeginPaint(const gfx::Rect& damage_rect);
// Called on FinishDrawingFrame. The compositor will no longer mutate the the
// SkCanvas instance returned by |BeginPaint| and should discard any reference
@@ -51,12 +51,12 @@ class CC_EXPORT SoftwareOutputDevice {
// Copies pixels inside |rect| from the current software framebuffer to
// |output|. Fails if there is no current softwareframebuffer.
- virtual void CopyToBitmap(gfx::Rect rect, SkBitmap* output);
+ virtual void CopyToBitmap(const gfx::Rect& rect, SkBitmap* output);
// Blit the pixel content of the SoftwareOutputDevice by |delta| with the
// write clipped to |clip_rect|.
virtual void Scroll(gfx::Vector2d delta,
- gfx::Rect clip_rect);
+ const gfx::Rect& clip_rect);
// Discard the backing buffer in the surface provided by this instance.
virtual void DiscardBackbuffer() {}