Add builders for tracing event's structural arguments

The new classes allow building JSON-like structural arguments. Current implementation uses base::Value as backing store but that can be replaced in the future with something more efficient without changing client code.

All clients of cc/debug/traced_value.h should eventually switch to use the new builders.

BUG=361045

Review URL: https://codereview.chromium.org/380763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286849 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 29 insertions, 17 deletions

diff --git a/cc/quads/draw_quad.cc b/cc/quads/draw_quad.cc
index b669ad7..38b24b0 100644
--- a/cc/quads/draw_quad.cc
+++ b/cc/quads/draw_quad.cc
@@ -4,6 +4,7 @@
 
 #include "cc/quads/draw_quad.h"
 
+#include "base/debug/trace_event_argument.h"
 #include "base/logging.h"
 #include "base/values.h"
 #include "cc/base/math_util.h"
@@ -56,48 +57,59 @@ void DrawQuad::SetAll(const SharedQuadState* shared_quad_state,
 DrawQuad::~DrawQuad() {
 }
 
-scoped_ptr<base::Value> DrawQuad::AsValue() const {
-  scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
+void DrawQuad::AsValueInto(base::debug::TracedValue* value) const {
   value->SetInteger("material", material);
-  value->Set("shared_state",
-             TracedValue::CreateIDRef(shared_quad_state).release());
+  TracedValue::SetIDRef(shared_quad_state, value, "shared_state");
+
+  value->BeginArray("content_space_rect");
+  MathUtil::AddToTracedValue(rect, value);
+  value->EndArray();
 
-  value->Set("content_space_rect", MathUtil::AsValue(rect).release());
   bool rect_is_clipped;
   gfx::QuadF rect_as_target_space_quad = MathUtil::MapQuad(
       shared_quad_state->content_to_target_transform,
       gfx::QuadF(rect),
       &rect_is_clipped);
-  value->Set("rect_as_target_space_quad",
-             MathUtil::AsValue(rect_as_target_space_quad).release());
+  value->BeginArray("rect_as_target_space_quad");
+  MathUtil::AddToTracedValue(rect_as_target_space_quad, value);
+  value->EndArray();
+
   value->SetBoolean("rect_is_clipped", rect_is_clipped);
 
-  value->Set("content_space_opaque_rect",
-             MathUtil::AsValue(opaque_rect).release());
+  value->BeginArray("content_space_opaque_rect");
+  MathUtil::AddToTracedValue(opaque_rect, value);
+  value->EndArray();
+
   bool opaque_rect_is_clipped;
   gfx::QuadF opaque_rect_as_target_space_quad = MathUtil::MapQuad(
       shared_quad_state->content_to_target_transform,
       gfx::QuadF(opaque_rect),
       &opaque_rect_is_clipped);
-  value->Set("opaque_rect_as_target_space_quad",
-             MathUtil::AsValue(opaque_rect_as_target_space_quad).release());
+  value->BeginArray("opaque_rect_as_target_space_quad");
+  MathUtil::AddToTracedValue(opaque_rect_as_target_space_quad, value);
+  value->EndArray();
+
   value->SetBoolean("opaque_rect_is_clipped", opaque_rect_is_clipped);
 
-  value->Set("content_space_visible_rect",
-             MathUtil::AsValue(visible_rect).release());
+  value->BeginArray("content_space_visible_rect");
+  MathUtil::AddToTracedValue(visible_rect, value);
+  value->EndArray();
+
   bool visible_rect_is_clipped;
   gfx::QuadF visible_rect_as_target_space_quad = MathUtil::MapQuad(
       shared_quad_state->content_to_target_transform,
       gfx::QuadF(visible_rect),
       &visible_rect_is_clipped);
-  value->Set("visible_rect_as_target_space_quad",
-             MathUtil::AsValue(visible_rect_as_target_space_quad).release());
+
+  value->BeginArray("visible_rect_as_target_space_quad");
+  MathUtil::AddToTracedValue(visible_rect_as_target_space_quad, value);
+  value->EndArray();
+
   value->SetBoolean("visible_rect_is_clipped", visible_rect_is_clipped);
 
   value->SetBoolean("needs_blending", needs_blending);
   value->SetBoolean("should_draw_with_blending", ShouldDrawWithBlending());
-  ExtendValue(value.get());
-  return value.PassAs<base::Value>();
+  ExtendValue(value);
 }
 
 }  // namespace cc