diff options
author | yurys@chromium.org <yurys@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-01 13:10:38 +0000 |
---|---|---|
committer | yurys@chromium.org <yurys@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-01 13:10:38 +0000 |
commit | d12aa932d3555eda2c011022e94df82023fa191d (patch) | |
tree | f1f9244b6beccfd2797d74fc1d1acea896d2a601 /cc/quads/texture_draw_quad.cc | |
parent | 59d75c8166ae16a7879c11595fbde2ab1cffad3b (diff) | |
download | chromium_src-d12aa932d3555eda2c011022e94df82023fa191d.zip chromium_src-d12aa932d3555eda2c011022e94df82023fa191d.tar.gz chromium_src-d12aa932d3555eda2c011022e94df82023fa191d.tar.bz2 |
Add builders for tracing event's structural arguments
The new classes allow building JSON-like structural arguments. Current implementation uses base::Value as backing store but that can be replaced in the future with something more efficient without changing client code.
All clients of cc/debug/traced_value.h should eventually switch to use the new builders.
BUG=361045
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286849
R=alph@chromium.org, dsinclair@chromium.org, nduca@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/380763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286984 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/quads/texture_draw_quad.cc')
-rw-r--r-- | cc/quads/texture_draw_quad.cc | 21 |
1 files changed, 15 insertions, 6 deletions
diff --git a/cc/quads/texture_draw_quad.cc b/cc/quads/texture_draw_quad.cc index 6637e4f..72435c2 100644 --- a/cc/quads/texture_draw_quad.cc +++ b/cc/quads/texture_draw_quad.cc @@ -4,6 +4,7 @@ #include "cc/quads/texture_draw_quad.h" +#include "base/debug/trace_event_argument.h" #include "base/logging.h" #include "base/values.h" #include "cc/base/math_util.h" @@ -83,16 +84,24 @@ const TextureDrawQuad* TextureDrawQuad::MaterialCast(const DrawQuad* quad) { return static_cast<const TextureDrawQuad*>(quad); } -void TextureDrawQuad::ExtendValue(base::DictionaryValue* value) const { +void TextureDrawQuad::ExtendValue(base::debug::TracedValue* value) const { value->SetInteger("resource_id", resource_id); value->SetBoolean("premultiplied_alpha", premultiplied_alpha); - value->Set("uv_top_left", MathUtil::AsValue(uv_top_left).release()); - value->Set("uv_bottom_right", MathUtil::AsValue(uv_bottom_right).release()); + value->BeginArray("uv_top_left"); + MathUtil::AddToTracedValue(uv_top_left, value); + value->EndArray(); + + value->BeginArray("uv_bottom_right"); + MathUtil::AddToTracedValue(uv_bottom_right, value); + value->EndArray(); + value->SetInteger("background_color", background_color); - scoped_ptr<base::ListValue> vertex_opacity_value(new base::ListValue); + + value->BeginArray("vertex_opacity"); for (size_t i = 0; i < 4; ++i) - vertex_opacity_value->AppendDouble(vertex_opacity[i]); - value->Set("vertex_opacity", vertex_opacity_value.release()); + value->AppendDouble(vertex_opacity[i]); + value->EndArray(); + value->SetBoolean("flipped", flipped); } |