diff options
| author | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
|---|---|---|
| committer | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
| commit | 0023fc78d056556b353ee17f03760bec8c1fee49 (patch) | |
| tree | 009367358a1c44b08f3142f63b087d936206ba44 /cc/quads/tile_draw_quad.cc | |
| parent | 37df32bd517577ac6ad20c6d76b236265caeacaf (diff) | |
| download | chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.zip chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.gz chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.bz2 | |
Pass gfx::Rect and gfx::RectF by const ref.
Avoid unneccessary copy of structures gfx::Rect & gfx::RectF
by passing them by const ref rather than value.
Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.
Pass by value creates unneccessary overhead which should be avoided.
BUG=159273
Review URL: https://codereview.chromium.org/93663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/quads/tile_draw_quad.cc')
| -rw-r--r-- | cc/quads/tile_draw_quad.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/cc/quads/tile_draw_quad.cc b/cc/quads/tile_draw_quad.cc index 3ff9809..60116cc 100644 --- a/cc/quads/tile_draw_quad.cc +++ b/cc/quads/tile_draw_quad.cc @@ -22,8 +22,8 @@ scoped_ptr<TileDrawQuad> TileDrawQuad::Create() { } void TileDrawQuad::SetNew(const SharedQuadState* shared_quad_state, - gfx::Rect rect, - gfx::Rect opaque_rect, + const gfx::Rect& rect, + const gfx::Rect& opaque_rect, unsigned resource_id, const gfx::RectF& tex_coord_rect, gfx::Size texture_size, @@ -35,9 +35,9 @@ void TileDrawQuad::SetNew(const SharedQuadState* shared_quad_state, } void TileDrawQuad::SetAll(const SharedQuadState* shared_quad_state, - gfx::Rect rect, - gfx::Rect opaque_rect, - gfx::Rect visible_rect, + const gfx::Rect& rect, + const gfx::Rect& opaque_rect, + const gfx::Rect& visible_rect, bool needs_blending, unsigned resource_id, const gfx::RectF& tex_coord_rect, |