diff options
author | hush <hush@chromium.org> | 2014-12-04 14:37:32 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-12-04 22:38:02 +0000 |
commit | 6b61421f5b702f90617ffeff3ed83ab044c55ad9 (patch) | |
tree | 58594f58c441c2f7675be1bd42b2e90ee4c0f802 /cc/quads | |
parent | 258cddfdb22627e42793771dc3a01f5b1cb1cc07 (diff) | |
download | chromium_src-6b61421f5b702f90617ffeff3ed83ab044c55ad9.zip chromium_src-6b61421f5b702f90617ffeff3ed83ab044c55ad9.tar.gz chromium_src-6b61421f5b702f90617ffeff3ed83ab044c55ad9.tar.bz2 |
Use EXPECT_EQ when possible.
EXPECT_RECT_EQ, EXPECT_SIZE_EQ, EXPECT_POINT_EQ, EXPECT_POINT3F_EQ
could be replaced by EXPECT_EQ.
Follow up of https://codereview.chromium.org/751453005/
Review URL: https://codereview.chromium.org/774763004
Cr-Commit-Position: refs/heads/master@{#306913}
Diffstat (limited to 'cc/quads')
-rw-r--r-- | cc/quads/draw_polygon_unittest.cc | 7 | ||||
-rw-r--r-- | cc/quads/draw_quad_unittest.cc | 48 | ||||
-rw-r--r-- | cc/quads/render_pass_unittest.cc | 8 |
3 files changed, 29 insertions, 34 deletions
diff --git a/cc/quads/draw_polygon_unittest.cc b/cc/quads/draw_polygon_unittest.cc index 27cfed4..360a014 100644 --- a/cc/quads/draw_polygon_unittest.cc +++ b/cc/quads/draw_polygon_unittest.cc @@ -19,16 +19,11 @@ namespace { #define EXPECT_FLOAT_WITHIN_EPSILON_OF(a, b) \ EXPECT_TRUE(std::abs(a - b) < std::numeric_limits<float>::epsilon()); -#define EXPECT_POINT_EQ(point_a, point_b) \ - EXPECT_FLOAT_EQ(point_a.x(), point_b.x()); \ - EXPECT_FLOAT_EQ(point_a.y(), point_b.y()); \ - EXPECT_FLOAT_EQ(point_a.z(), point_b.z()); - static void ValidatePoints(const DrawPolygon& polygon, const std::vector<gfx::Point3F>& points) { EXPECT_EQ(polygon.points().size(), points.size()); for (size_t i = 0; i < points.size(); i++) { - EXPECT_POINT_EQ(polygon.points()[i], points[i]); + EXPECT_EQ(polygon.points()[i], points[i]); } } diff --git a/cc/quads/draw_quad_unittest.cc b/cc/quads/draw_quad_unittest.cc index 95c646b..e65b326 100644 --- a/cc/quads/draw_quad_unittest.cc +++ b/cc/quads/draw_quad_unittest.cc @@ -55,9 +55,9 @@ TEST(DrawQuadTest, CopySharedQuadState) { scoped_ptr<SharedQuadState> copy(new SharedQuadState); copy->CopyFrom(state.get()); EXPECT_EQ(quad_transform, copy->content_to_target_transform); - EXPECT_RECT_EQ(visible_content_rect, copy->visible_content_rect); + EXPECT_EQ(visible_content_rect, copy->visible_content_rect); EXPECT_EQ(opacity, copy->opacity); - EXPECT_RECT_EQ(clip_rect, copy->clip_rect); + EXPECT_EQ(clip_rect, copy->clip_rect); EXPECT_EQ(is_clipped, copy->is_clipped); EXPECT_EQ(blend_mode, copy->blend_mode); } @@ -88,9 +88,9 @@ void CompareDrawQuad(DrawQuad* quad, DrawQuad* copy, SharedQuadState* copy_shared_state) { EXPECT_EQ(quad->material, copy->material); - EXPECT_RECT_EQ(quad->rect, copy->rect); - EXPECT_RECT_EQ(quad->visible_rect, copy->visible_rect); - EXPECT_RECT_EQ(quad->opaque_rect, copy->opaque_rect); + EXPECT_EQ(quad->rect, copy->rect); + EXPECT_EQ(quad->visible_rect, copy->visible_rect); + EXPECT_EQ(quad->opaque_rect, copy->opaque_rect); EXPECT_EQ(quad->needs_blending, copy->needs_blending); EXPECT_EQ(copy_shared_state, copy->shared_quad_state); } @@ -373,7 +373,7 @@ TEST(DrawQuadTest, CopyCheckerboardDrawQuad) { CREATE_QUAD_2_NEW(CheckerboardDrawQuad, visible_rect, color); EXPECT_EQ(DrawQuad::CHECKERBOARD, copy_quad->material); - EXPECT_RECT_EQ(visible_rect, copy_quad->visible_rect); + EXPECT_EQ(visible_rect, copy_quad->visible_rect); EXPECT_EQ(color, copy_quad->color); CREATE_QUAD_1_ALL(CheckerboardDrawQuad, color); @@ -389,7 +389,7 @@ TEST(DrawQuadTest, CopyDebugBorderDrawQuad) { CREATE_QUAD_3_NEW(DebugBorderDrawQuad, visible_rect, color, width); EXPECT_EQ(DrawQuad::DEBUG_BORDER, copy_quad->material); - EXPECT_RECT_EQ(visible_rect, copy_quad->visible_rect); + EXPECT_EQ(visible_rect, copy_quad->visible_rect); EXPECT_EQ(color, copy_quad->color); EXPECT_EQ(width, copy_quad->width); @@ -414,8 +414,8 @@ TEST(DrawQuadTest, CopyIOSurfaceDrawQuad) { resource_id, orientation); EXPECT_EQ(DrawQuad::IO_SURFACE_CONTENT, copy_quad->material); - EXPECT_RECT_EQ(visible_rect, copy_quad->visible_rect); - EXPECT_RECT_EQ(opaque_rect, copy_quad->opaque_rect); + EXPECT_EQ(visible_rect, copy_quad->visible_rect); + EXPECT_EQ(opaque_rect, copy_quad->opaque_rect); EXPECT_EQ(size, copy_quad->io_surface_size); EXPECT_EQ(resource_id, copy_quad->io_surface_resource_id); EXPECT_EQ(orientation, copy_quad->orientation); @@ -454,7 +454,7 @@ TEST(DrawQuadTest, CopyRenderPassDrawQuad) { background_filters, copied_render_pass_id); EXPECT_EQ(DrawQuad::RENDER_PASS, copy_quad->material); - EXPECT_RECT_EQ(visible_rect, copy_quad->visible_rect); + EXPECT_EQ(visible_rect, copy_quad->visible_rect); EXPECT_EQ(copied_render_pass_id, copy_quad->render_pass_id); EXPECT_EQ(mask_resource_id, copy_quad->mask_resource_id); EXPECT_EQ(mask_uv_scale.ToString(), copy_quad->mask_uv_scale.ToString()); @@ -493,7 +493,7 @@ TEST(DrawQuadTest, CopySolidColorDrawQuad) { CREATE_QUAD_3_NEW( SolidColorDrawQuad, visible_rect, color, force_anti_aliasing_off); EXPECT_EQ(DrawQuad::SOLID_COLOR, copy_quad->material); - EXPECT_RECT_EQ(visible_rect, copy_quad->visible_rect); + EXPECT_EQ(visible_rect, copy_quad->visible_rect); EXPECT_EQ(color, copy_quad->color); EXPECT_EQ(force_anti_aliasing_off, copy_quad->force_anti_aliasing_off); @@ -513,8 +513,8 @@ TEST(DrawQuadTest, CopyStreamVideoDrawQuad) { CREATE_QUAD_4_NEW( StreamVideoDrawQuad, opaque_rect, visible_rect, resource_id, matrix); EXPECT_EQ(DrawQuad::STREAM_VIDEO_CONTENT, copy_quad->material); - EXPECT_RECT_EQ(visible_rect, copy_quad->visible_rect); - EXPECT_RECT_EQ(opaque_rect, copy_quad->opaque_rect); + EXPECT_EQ(visible_rect, copy_quad->visible_rect); + EXPECT_EQ(opaque_rect, copy_quad->opaque_rect); EXPECT_EQ(resource_id, copy_quad->resource_id); EXPECT_EQ(matrix, copy_quad->matrix); @@ -531,7 +531,7 @@ TEST(DrawQuadTest, CopySurfaceDrawQuad) { CREATE_QUAD_2_NEW(SurfaceDrawQuad, visible_rect, surface_id); EXPECT_EQ(DrawQuad::SURFACE_CONTENT, copy_quad->material); - EXPECT_RECT_EQ(visible_rect, copy_quad->visible_rect); + EXPECT_EQ(visible_rect, copy_quad->visible_rect); EXPECT_EQ(surface_id, copy_quad->surface_id); CREATE_QUAD_1_ALL(SurfaceDrawQuad, surface_id); @@ -564,8 +564,8 @@ TEST(DrawQuadTest, CopyTextureDrawQuad) { flipped, nearest_neighbor); EXPECT_EQ(DrawQuad::TEXTURE_CONTENT, copy_quad->material); - EXPECT_RECT_EQ(visible_rect, copy_quad->visible_rect); - EXPECT_RECT_EQ(opaque_rect, copy_quad->opaque_rect); + EXPECT_EQ(visible_rect, copy_quad->visible_rect); + EXPECT_EQ(opaque_rect, copy_quad->opaque_rect); EXPECT_EQ(resource_id, copy_quad->resource_id); EXPECT_EQ(premultiplied_alpha, copy_quad->premultiplied_alpha); EXPECT_EQ(uv_top_left, copy_quad->uv_top_left); @@ -610,8 +610,8 @@ TEST(DrawQuadTest, CopyTileDrawQuad) { texture_size, swizzle_contents); EXPECT_EQ(DrawQuad::TILED_CONTENT, copy_quad->material); - EXPECT_RECT_EQ(opaque_rect, copy_quad->opaque_rect); - EXPECT_RECT_EQ(visible_rect, copy_quad->visible_rect); + EXPECT_EQ(opaque_rect, copy_quad->opaque_rect); + EXPECT_EQ(visible_rect, copy_quad->visible_rect); EXPECT_EQ(resource_id, copy_quad->resource_id); EXPECT_EQ(tex_coord_rect, copy_quad->tex_coord_rect); EXPECT_EQ(texture_size, copy_quad->texture_size); @@ -650,8 +650,8 @@ TEST(DrawQuadTest, CopyYUVVideoDrawQuad) { a_plane_resource_id, color_space); EXPECT_EQ(DrawQuad::YUV_VIDEO_CONTENT, copy_quad->material); - EXPECT_RECT_EQ(opaque_rect, copy_quad->opaque_rect); - EXPECT_RECT_EQ(visible_rect, copy_quad->visible_rect); + EXPECT_EQ(opaque_rect, copy_quad->opaque_rect); + EXPECT_EQ(visible_rect, copy_quad->visible_rect); EXPECT_EQ(tex_coord_rect, copy_quad->tex_coord_rect); EXPECT_EQ(y_plane_resource_id, copy_quad->y_plane_resource_id); EXPECT_EQ(u_plane_resource_id, copy_quad->u_plane_resource_id); @@ -690,12 +690,12 @@ TEST(DrawQuadTest, CopyPictureDrawQuad) { texture_size, texture_format, content_rect, contents_scale, raster_source); EXPECT_EQ(DrawQuad::PICTURE_CONTENT, copy_quad->material); - EXPECT_RECT_EQ(opaque_rect, copy_quad->opaque_rect); - EXPECT_RECT_EQ(visible_rect, copy_quad->visible_rect); + EXPECT_EQ(opaque_rect, copy_quad->opaque_rect); + EXPECT_EQ(visible_rect, copy_quad->visible_rect); EXPECT_EQ(tex_coord_rect, copy_quad->tex_coord_rect); EXPECT_EQ(texture_size, copy_quad->texture_size); EXPECT_EQ(texture_format, copy_quad->texture_format); - EXPECT_RECT_EQ(content_rect, copy_quad->content_rect); + EXPECT_EQ(content_rect, copy_quad->content_rect); EXPECT_EQ(contents_scale, copy_quad->contents_scale); EXPECT_EQ(raster_source, copy_quad->raster_source); @@ -706,7 +706,7 @@ TEST(DrawQuadTest, CopyPictureDrawQuad) { EXPECT_EQ(tex_coord_rect, copy_quad->tex_coord_rect); EXPECT_EQ(texture_size, copy_quad->texture_size); EXPECT_EQ(texture_format, copy_quad->texture_format); - EXPECT_RECT_EQ(content_rect, copy_quad->content_rect); + EXPECT_EQ(content_rect, copy_quad->content_rect); EXPECT_EQ(contents_scale, copy_quad->contents_scale); EXPECT_EQ(raster_source, copy_quad->raster_source); } diff --git a/cc/quads/render_pass_unittest.cc b/cc/quads/render_pass_unittest.cc index 4c3753f..8775d81 100644 --- a/cc/quads/render_pass_unittest.cc +++ b/cc/quads/render_pass_unittest.cc @@ -41,10 +41,10 @@ static void CompareRenderPassLists(const RenderPassList& expected_list, RenderPass* actual = actual_list[i]; EXPECT_EQ(expected->id, actual->id); - EXPECT_RECT_EQ(expected->output_rect, actual->output_rect); + EXPECT_EQ(expected->output_rect, actual->output_rect); EXPECT_EQ(expected->transform_to_root_target, actual->transform_to_root_target); - EXPECT_RECT_EQ(expected->damage_rect, actual->damage_rect); + EXPECT_EQ(expected->damage_rect, actual->damage_rect); EXPECT_EQ(expected->has_transparent_background, actual->has_transparent_background); @@ -99,9 +99,9 @@ TEST(RenderPassTest, CopyShouldBeIdenticalExceptIdAndQuads) { scoped_ptr<RenderPass> copy = pass->Copy(new_id); EXPECT_EQ(new_id, copy->id); - EXPECT_RECT_EQ(pass->output_rect, copy->output_rect); + EXPECT_EQ(pass->output_rect, copy->output_rect); EXPECT_EQ(pass->transform_to_root_target, copy->transform_to_root_target); - EXPECT_RECT_EQ(pass->damage_rect, copy->damage_rect); + EXPECT_EQ(pass->damage_rect, copy->damage_rect); EXPECT_EQ(pass->has_transparent_background, copy->has_transparent_background); EXPECT_EQ(0u, copy->quad_list.size()); |