summaryrefslogtreecommitdiffstats
path: root/cc/quads
diff options
context:
space:
mode:
authorjbauman <jbauman@chromium.org>2015-05-18 17:33:35 -0700
committerCommit bot <commit-bot@chromium.org>2015-05-19 00:33:50 +0000
commitbbd425e075be8416cdc1d83a0b3907c17194a6ae (patch)
treeac094de8f9ee59fb8c115202c7018538ed4d9c5a /cc/quads
parentb5814778060deb32c31605bfe0b82cd2baeae866 (diff)
downloadchromium_src-bbd425e075be8416cdc1d83a0b3907c17194a6ae.zip
chromium_src-bbd425e075be8416cdc1d83a0b3907c17194a6ae.tar.gz
chromium_src-bbd425e075be8416cdc1d83a0b3907c17194a6ae.tar.bz2
Rename cc::ResourceProvider::ResourceId to cc::ResourceId and move it to its own file.
This allows files like surface_resource_holder.h and transferable_resource.h to depend on the typedef without depending on resource_provider.h Review URL: https://codereview.chromium.org/1144523003 Cr-Commit-Position: refs/heads/master@{#330459}
Diffstat (limited to 'cc/quads')
-rw-r--r--cc/quads/draw_quad.h1
-rw-r--r--cc/quads/draw_quad_unittest.cc31
-rw-r--r--cc/quads/render_pass_draw_quad.cc6
-rw-r--r--cc/quads/render_pass_draw_quad.h6
4 files changed, 21 insertions, 23 deletions
diff --git a/cc/quads/draw_quad.h b/cc/quads/draw_quad.h
index 3897d1d..0e26b63 100644
--- a/cc/quads/draw_quad.h
+++ b/cc/quads/draw_quad.h
@@ -96,7 +96,6 @@ class CC_EXPORT DrawQuad {
return !opaque_rect.Contains(visible_rect);
}
- typedef ResourceProvider::ResourceId ResourceId;
typedef base::Callback<ResourceId(ResourceId)> ResourceIteratorCallback;
virtual void IterateResources(const ResourceIteratorCallback& callback) = 0;
diff --git a/cc/quads/draw_quad_unittest.cc b/cc/quads/draw_quad_unittest.cc
index 968a1d0..e66bcdf 100644
--- a/cc/quads/draw_quad_unittest.cc
+++ b/cc/quads/draw_quad_unittest.cc
@@ -404,7 +404,7 @@ TEST(DrawQuadTest, CopyIOSurfaceDrawQuad) {
gfx::Rect opaque_rect(33, 47, 10, 12);
gfx::Rect visible_rect(40, 50, 30, 20);
gfx::Size size(58, 95);
- ResourceProvider::ResourceId resource_id = 72;
+ ResourceId resource_id = 72;
IOSurfaceDrawQuad::Orientation orientation = IOSurfaceDrawQuad::UNFLIPPED;
CREATE_SHARED_STATE();
@@ -431,7 +431,7 @@ TEST(DrawQuadTest, CopyIOSurfaceDrawQuad) {
TEST(DrawQuadTest, CopyRenderPassDrawQuad) {
gfx::Rect visible_rect(40, 50, 30, 20);
RenderPassId render_pass_id(22, 64);
- ResourceProvider::ResourceId mask_resource_id = 78;
+ ResourceId mask_resource_id = 78;
gfx::Vector2dF mask_uv_scale(33.f, 19.f);
gfx::Size mask_texture_size(128, 134);
FilterOperations filters;
@@ -507,7 +507,7 @@ TEST(DrawQuadTest, CopySolidColorDrawQuad) {
TEST(DrawQuadTest, CopyStreamVideoDrawQuad) {
gfx::Rect opaque_rect(33, 47, 10, 12);
gfx::Rect visible_rect(40, 50, 30, 20);
- ResourceProvider::ResourceId resource_id = 64;
+ ResourceId resource_id = 64;
gfx::Transform matrix = gfx::Transform(0.5, 0.25, 1, 0.75, 0, 1);
CREATE_SHARED_STATE();
@@ -642,10 +642,10 @@ TEST(DrawQuadTest, CopyYUVVideoDrawQuad) {
gfx::RectF uv_tex_coord_rect(20, 25, 15, 10);
gfx::Size ya_tex_size(32, 68);
gfx::Size uv_tex_size(41, 51);
- ResourceProvider::ResourceId y_plane_resource_id = 45;
- ResourceProvider::ResourceId u_plane_resource_id = 532;
- ResourceProvider::ResourceId v_plane_resource_id = 4;
- ResourceProvider::ResourceId a_plane_resource_id = 63;
+ ResourceId y_plane_resource_id = 45;
+ ResourceId u_plane_resource_id = 532;
+ ResourceId v_plane_resource_id = 4;
+ ResourceId a_plane_resource_id = 63;
YUVVideoDrawQuad::ColorSpace color_space = YUVVideoDrawQuad::JPEG;
CREATE_SHARED_STATE();
@@ -725,8 +725,7 @@ TEST(DrawQuadTest, CopyPictureDrawQuad) {
class DrawQuadIteratorTest : public testing::Test {
protected:
- ResourceProvider::ResourceId IncrementResourceId(
- ResourceProvider::ResourceId id) {
+ ResourceId IncrementResourceId(ResourceId id) {
++num_resources_;
return id + 1;
}
@@ -766,7 +765,7 @@ TEST_F(DrawQuadIteratorTest, IOSurfaceDrawQuad) {
gfx::Rect opaque_rect(33, 47, 10, 12);
gfx::Rect visible_rect(40, 50, 30, 20);
gfx::Size size(58, 95);
- ResourceProvider::ResourceId resource_id = 72;
+ ResourceId resource_id = 72;
IOSurfaceDrawQuad::Orientation orientation = IOSurfaceDrawQuad::UNFLIPPED;
CREATE_SHARED_STATE();
@@ -784,7 +783,7 @@ TEST_F(DrawQuadIteratorTest, IOSurfaceDrawQuad) {
TEST_F(DrawQuadIteratorTest, RenderPassDrawQuad) {
gfx::Rect visible_rect(40, 50, 30, 20);
RenderPassId render_pass_id(22, 64);
- ResourceProvider::ResourceId mask_resource_id = 78;
+ ResourceId mask_resource_id = 78;
gfx::Vector2dF mask_uv_scale(33.f, 19.f);
gfx::Size mask_texture_size(128, 134);
FilterOperations filters;
@@ -829,7 +828,7 @@ TEST_F(DrawQuadIteratorTest, SolidColorDrawQuad) {
TEST_F(DrawQuadIteratorTest, StreamVideoDrawQuad) {
gfx::Rect opaque_rect(33, 47, 10, 12);
gfx::Rect visible_rect(40, 50, 30, 20);
- ResourceProvider::ResourceId resource_id = 64;
+ ResourceId resource_id = 64;
gfx::Transform matrix = gfx::Transform(0.5, 0.25, 1, 0.75, 0, 1);
CREATE_SHARED_STATE();
@@ -907,10 +906,10 @@ TEST_F(DrawQuadIteratorTest, YUVVideoDrawQuad) {
gfx::RectF uv_tex_coord_rect(0.0f, 0.0f, 0.375f, 0.25f);
gfx::Size ya_tex_size(32, 68);
gfx::Size uv_tex_size(41, 51);
- ResourceProvider::ResourceId y_plane_resource_id = 45;
- ResourceProvider::ResourceId u_plane_resource_id = 532;
- ResourceProvider::ResourceId v_plane_resource_id = 4;
- ResourceProvider::ResourceId a_plane_resource_id = 63;
+ ResourceId y_plane_resource_id = 45;
+ ResourceId u_plane_resource_id = 532;
+ ResourceId v_plane_resource_id = 4;
+ ResourceId a_plane_resource_id = 63;
YUVVideoDrawQuad::ColorSpace color_space = YUVVideoDrawQuad::JPEG;
CREATE_SHARED_STATE();
diff --git a/cc/quads/render_pass_draw_quad.cc b/cc/quads/render_pass_draw_quad.cc
index 963a190..ee9c748 100644
--- a/cc/quads/render_pass_draw_quad.cc
+++ b/cc/quads/render_pass_draw_quad.cc
@@ -14,7 +14,7 @@ namespace cc {
RenderPassDrawQuad::RenderPassDrawQuad()
: render_pass_id(RenderPassId(-1, -1)),
- mask_resource_id(static_cast<ResourceProvider::ResourceId>(-1)) {
+ mask_resource_id(static_cast<ResourceId>(-1)) {
}
RenderPassDrawQuad::~RenderPassDrawQuad() {
@@ -24,7 +24,7 @@ void RenderPassDrawQuad::SetNew(const SharedQuadState* shared_quad_state,
const gfx::Rect& rect,
const gfx::Rect& visible_rect,
RenderPassId render_pass_id,
- ResourceProvider::ResourceId mask_resource_id,
+ ResourceId mask_resource_id,
const gfx::Vector2dF& mask_uv_scale,
const gfx::Size& mask_texture_size,
const FilterOperations& filters,
@@ -55,7 +55,7 @@ void RenderPassDrawQuad::SetAll(const SharedQuadState* shared_quad_state,
const gfx::Rect& visible_rect,
bool needs_blending,
RenderPassId render_pass_id,
- ResourceProvider::ResourceId mask_resource_id,
+ ResourceId mask_resource_id,
const gfx::Vector2dF& mask_uv_scale,
const gfx::Size& mask_texture_size,
const FilterOperations& filters,
diff --git a/cc/quads/render_pass_draw_quad.h b/cc/quads/render_pass_draw_quad.h
index 758b8e8..7e989d4 100644
--- a/cc/quads/render_pass_draw_quad.h
+++ b/cc/quads/render_pass_draw_quad.h
@@ -24,7 +24,7 @@ class CC_EXPORT RenderPassDrawQuad : public DrawQuad {
const gfx::Rect& rect,
const gfx::Rect& visible_rect,
RenderPassId render_pass_id,
- ResourceProvider::ResourceId mask_resource_id,
+ ResourceId mask_resource_id,
const gfx::Vector2dF& mask_uv_scale,
const gfx::Size& mask_texture_size,
const FilterOperations& filters,
@@ -37,7 +37,7 @@ class CC_EXPORT RenderPassDrawQuad : public DrawQuad {
const gfx::Rect& visible_rect,
bool needs_blending,
RenderPassId render_pass_id,
- ResourceProvider::ResourceId mask_resource_id,
+ ResourceId mask_resource_id,
const gfx::Vector2dF& mask_uv_scale,
const gfx::Size& mask_texture_size,
const FilterOperations& filters,
@@ -45,7 +45,7 @@ class CC_EXPORT RenderPassDrawQuad : public DrawQuad {
const FilterOperations& background_filters);
RenderPassId render_pass_id;
- ResourceProvider::ResourceId mask_resource_id;
+ ResourceId mask_resource_id;
gfx::Vector2dF mask_uv_scale;
gfx::Size mask_texture_size;