diff options
| author | Daichi Hirono <hirono@chromium.org> | 2015-06-26 19:54:32 +0900 |
|---|---|---|
| committer | Daichi Hirono <hirono@chromium.org> | 2015-06-26 10:55:20 +0000 |
| commit | 300a99c98503a37d3c97507ef570fce7aa8ba976 (patch) | |
| tree | 46eff0e5cc0cd5f9a03e4cac1ac772f3e07437b9 /cc/resources/prioritized_resource_unittest.cc | |
| parent | 150d64bcd7bd6a19b356b111c14f58db55a8ac1a (diff) | |
| download | chromium_src-300a99c98503a37d3c97507ef570fce7aa8ba976.zip chromium_src-300a99c98503a37d3c97507ef570fce7aa8ba976.tar.gz chromium_src-300a99c98503a37d3c97507ef570fce7aa8ba976.tar.bz2 | |
Fix crash in drive::BatchRequestConfigurator::MultipartUploadNewFile.
Previously the configuretor held the batch request to configure, and it
assumed the batch request has not been released before it is committed. But the
batch request was passed to request sender when it is created, and actually the request
sender could release the batch request before sending it when pre-authentication
was failure. Thus it crashed when adding new child request to the released batch
request.
The CL adds check for the batch request, and passes DRIVE_OTHER_ERROR for child
requests in the case that the parent batch request has already been released.
BUG=503433
TEST=DriveAPIServiceTest.BatchRequestConfiguratorWithAuthFailure
TBR=mtomasz@chromium.org,kinaba@chromium.org
Review URL: https://codereview.chromium.org/1198273009
Cr-Commit-Position: refs/heads/master@{#336098}
(cherry picked from commit 98b515b0378d5b88de9f6901f8bc726a94ce6ec4)
Review URL: https://codereview.chromium.org/1209253003.
Cr-Commit-Position: refs/branch-heads/2403@{#406}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Diffstat (limited to 'cc/resources/prioritized_resource_unittest.cc')
0 files changed, 0 insertions, 0 deletions