diff options
author | kuan@chromium.org <kuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-07 20:26:13 +0000 |
---|---|---|
committer | kuan@chromium.org <kuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-07 20:26:13 +0000 |
commit | 5dd6986c8dcb3342f00dd7514d058ccb68f1e893 (patch) | |
tree | 4a4c74b69b1a9242df81c9f6d2f73ca2a5e987ae /cc/resources/tile.h | |
parent | afcb1c40717b8954c9ed506160b46b548b21123e (diff) | |
download | chromium_src-5dd6986c8dcb3342f00dd7514d058ccb68f1e893.zip chromium_src-5dd6986c8dcb3342f00dd7514d058ccb68f1e893.tar.gz chromium_src-5dd6986c8dcb3342f00dd7514d058ccb68f1e893.tar.bz2 |
Revert 227029 "reland "views: change WrenchMenu to use each mode..."
> reland "views: change WrenchMenu to use each model's command ID's when creating MenuItemView's"
>
> this fixes the static initializer error in r226778 (https://codereview.chromium.org/25811003), and a bug in BookmarkMenuDelegate.
>
> this is in preparation for dynamic recent tabs model and menu:
>
> * WrenchMenu:
> - for each menu item, MenuItemView::GetCommand() used to be separate and different from MenuModel::GetCommandIdAt(model_index); they are the same now.
> - different range of command id's are reserved for recent tabs and bookmarks.
> - command id's of all items in the wrench menu and all its submenus can't clash, except for separator and IDC_SHOW_HISTORY, the latter of which is in both wrench menu and recent tabs submenu.
>
> * RecentTabsSubMenuModel:
> - make all command ids within range, use different ids among device name headers.
>
> BUG=256750
> TEST=wrench menu and all its submenus still work.
>
> Review URL: https://codereview.chromium.org/25667005
TBR=kuan@chromium.org
Review URL: https://codereview.chromium.org/26294006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227334 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/resources/tile.h')
0 files changed, 0 insertions, 0 deletions