diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-02 00:22:53 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-02 00:22:53 +0000 |
| commit | 2672d2862a8a621285026d3c4d3b14448606522a (patch) | |
| tree | 662ed54b5933563007e234ae2f36d1873ff2664a /cc/test/CCLayerTestCommon.cpp | |
| parent | 947fe47c56ca3c165d45cb4bc6103c6238566da3 (diff) | |
| download | chromium_src-2672d2862a8a621285026d3c4d3b14448606522a.zip chromium_src-2672d2862a8a621285026d3c4d3b14448606522a.tar.gz chromium_src-2672d2862a8a621285026d3c4d3b14448606522a.tar.bz2 | |
sync: Remove ChangeProcessor::Stop()
Stopping the ChangeProcessor from the UI is racy, especially for data
types with controllers that directly extend
NonFrontendDataTypeController. This can lead to crashes or DCHECK
failures.
It turns out that the easiest way to fix this is to not Stop() the
ChangeProcessors from the UI thread. There are no data types that
require this functionality. It is at best unnecessary and at worst
harmful.
Without Stop(), there is no longer any need to check if a
ChangeProcessor is running. Therefore, running_ and its associated
methods, DCHECKs, etc. have been removed, too.
BUG=151606
Review URL: https://chromiumcodereview.appspot.com/10979067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159600 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/test/CCLayerTestCommon.cpp')
0 files changed, 0 insertions, 0 deletions