diff options
| author | skyostil@google.com <skyostil@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-20 13:03:52 +0000 |
|---|---|---|
| committer | skyostil@google.com <skyostil@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-20 13:03:52 +0000 |
| commit | 27af5884d3b5e1973bb3825ab1960ee312ea5fe4 (patch) | |
| tree | 4cc47a7b53090dcf6369300b8034dec16af0ecc2 /cc/test/fake_picture_layer_tiling_client.h | |
| parent | 526a16b1a62d0e11bc7da18de694143c61613e71 (diff) | |
| download | chromium_src-27af5884d3b5e1973bb3825ab1960ee312ea5fe4.zip chromium_src-27af5884d3b5e1973bb3825ab1960ee312ea5fe4.tar.gz chromium_src-27af5884d3b5e1973bb3825ab1960ee312ea5fe4.tar.bz2 | |
Revert 207360 "cc: Recycle tilings to make SetLiveTilesRect cheaper"
PictureLayerTilingSetSyncTest.Invalidation seems to be flaky on Android. For example:
http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28JB%20GalaxyNexus%29%28dbg%29/builds/12538/steps/cc_unittests/logs/stdio
> cc: Recycle tilings to make SetLiveTilesRect cheaper
>
> Rather than recreating new tilings every frame, use the tilings and old tiles
> from the recycle tree in order to prevent excessive amounts of tile allocations
> (1 per tile) during the first update. In order to reuse a tiling from two
> frames ago, the tilings must be resized, invalidated, have their pile updated,
> and also any missing tiles that can now be rastered need to be filled in.
>
> This brings back a bunch of functions that were removed in
> https://codereview.chromium.org/14600003/ to enable tilings to be resized and
> updated at times other than SetLiveTilesRect.
>
> This patch makes SetLiveTilesRect on the pending tree go from 2.2ms to 0.16ms
> on average on an N4 for the heavy page linked in the bug with ~700 tiles. On a
> page with about 300 tiles and fewer commits, this patch is a slight win but is
> mostly in the noise.
>
> R=danakj@chromium.org
> BUG=248954
>
> Review URL: https://chromiumcodereview.appspot.com/16888016
TBR=enne@chromium.org
Review URL: https://codereview.chromium.org/17176009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207405 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/test/fake_picture_layer_tiling_client.h')
| -rw-r--r-- | cc/test/fake_picture_layer_tiling_client.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/cc/test/fake_picture_layer_tiling_client.h b/cc/test/fake_picture_layer_tiling_client.h index d32cb1e..3593661 100644 --- a/cc/test/fake_picture_layer_tiling_client.h +++ b/cc/test/fake_picture_layer_tiling_client.h @@ -29,7 +29,6 @@ class FakePictureLayerTilingClient : public PictureLayerTilingClient { void SetTileSize(gfx::Size tile_size); gfx::Size TileSize() const { return tile_size_; } scoped_refptr<PicturePileImpl> pile() { return pile_; } - const PicturePileImpl* pile() const { return pile_; } virtual const Region* GetInvalidation() OVERRIDE; virtual const PictureLayerTiling* GetTwinTiling( |