diff options
author | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-18 18:15:04 +0000 |
---|---|---|
committer | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-18 18:15:04 +0000 |
commit | 1d99317a73040007668b1cdf134334f45d45600e (patch) | |
tree | 0da28120111aa69a339ec90ff05d7cac8b21cf77 /cc/tiled_layer.cc | |
parent | 52f1a7e63128f2a4f644e1a28a6744b916585999 (diff) | |
download | chromium_src-1d99317a73040007668b1cdf134334f45d45600e.zip chromium_src-1d99317a73040007668b1cdf134334f45d45600e.tar.gz chromium_src-1d99317a73040007668b1cdf134334f45d45600e.tar.bz2 |
cc: Switch to Chromium DCHECKs LOGs
We can't compile-guard code and use DCHECK since it can be enabled at runtime. So we guard the DCHECKs that we want to rely on conditionally-compiled code in !NDEBUG compile guards.
This also replaces use of LOG_ERROR("Foo") with LOG(ERROR)<<"Foo";
This was previously discussed and committed as https://codereview.chromium.org/11048044/
using a guard based on LOGGING_IS_OFFICIAL_BUILD, however this was not sufficient since there are build configurations that are official builds but have dchecks compiled.
R=enne
Review URL: https://codereview.chromium.org/11192030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162739 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/tiled_layer.cc')
-rw-r--r-- | cc/tiled_layer.cc | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/cc/tiled_layer.cc b/cc/tiled_layer.cc index 1ea1e25..e7adf54 100644 --- a/cc/tiled_layer.cc +++ b/cc/tiled_layer.cc @@ -97,7 +97,7 @@ scoped_ptr<CCLayerImpl> TiledLayerChromium::createCCLayerImpl() void TiledLayerChromium::updateTileSizeAndTilingOption() { - ASSERT(layerTreeHost()); + DCHECK(layerTreeHost()); const IntSize& defaultTileSize = layerTreeHost()->settings().defaultTileSize; const IntSize& maxUntiledLayerSize = layerTreeHost()->settings().maxUntiledLayerSize; @@ -309,7 +309,7 @@ void TiledLayerChromium::invalidateContentRect(const IntRect& contentRect) for (CCLayerTilingData::TileMap::const_iterator iter = m_tiler->tiles().begin(); iter != m_tiler->tiles().end(); ++iter) { UpdatableTile* tile = static_cast<UpdatableTile*>(iter->second); - ASSERT(tile); + DCHECK(tile); // FIXME: This should not ever be null. if (!tile) continue; @@ -379,11 +379,11 @@ void TiledLayerChromium::markOcclusionsAndRequestTextures(int left, int top, int for (int j = top; j <= bottom; ++j) { for (int i = left; i <= right; ++i) { UpdatableTile* tile = tileAt(i, j); - ASSERT(tile); // Did setTexturePriorities get skipped? + DCHECK(tile); // Did setTexturePriorities get skipped? // FIXME: This should not ever be null. if (!tile) continue; - ASSERT(!tile->occluded); // Did resetUpdateState get skipped? Are we doing more than one occlusion pass? + DCHECK(!tile->occluded); // Did resetUpdateState get skipped? Are we doing more than one occlusion pass? IntRect visibleTileRect = intersection(m_tiler->tileBounds(i, j), visibleContentRect()); if (occlusion && occlusion->occluded(this, visibleTileRect)) { tile->occluded = true; @@ -407,7 +407,7 @@ bool TiledLayerChromium::haveTexturesForTiles(int left, int top, int right, int for (int j = top; j <= bottom; ++j) { for (int i = left; i <= right; ++i) { UpdatableTile* tile = tileAt(i, j); - ASSERT(tile); // Did setTexturePriorites get skipped? + DCHECK(tile); // Did setTexturePriorites get skipped? // FIXME: This should not ever be null. if (!tile) continue; @@ -434,7 +434,7 @@ IntRect TiledLayerChromium::markTilesForUpdate(int left, int top, int right, int for (int j = top; j <= bottom; ++j) { for (int i = left; i <= right; ++i) { UpdatableTile* tile = tileAt(i, j); - ASSERT(tile); // Did setTexturePriorites get skipped? + DCHECK(tile); // Did setTexturePriorites get skipped? // FIXME: This should not ever be null. if (!tile) continue; @@ -466,7 +466,7 @@ void TiledLayerChromium::updateTileTextures(const IntRect& paintRect, int left, for (int j = top; j <= bottom; ++j) { for (int i = left; i <= right; ++i) { UpdatableTile* tile = tileAt(i, j); - ASSERT(tile); // Did setTexturePriorites get skipped? + DCHECK(tile); // Did setTexturePriorites get skipped? // FIXME: This should not ever be null. if (!tile) continue; @@ -667,7 +667,7 @@ void TiledLayerChromium::resetUpdateState() void TiledLayerChromium::update(CCTextureUpdateQueue& queue, const CCOcclusionTracker* occlusion, CCRenderingStats& stats) { - ASSERT(!m_skipsDraw && !m_failedUpdate); // Did resetUpdateState get skipped? + DCHECK(!m_skipsDraw && !m_failedUpdate); // Did resetUpdateState get skipped? updateBounds(); if (m_tiler->hasEmptyBounds() || !drawsContent()) return; @@ -754,7 +754,7 @@ bool TiledLayerChromium::needsIdlePaint() for (int j = top; j <= bottom; ++j) { for (int i = left; i <= right; ++i) { UpdatableTile* tile = tileAt(i, j); - ASSERT(tile); // Did setTexturePriorities get skipped? + DCHECK(tile); // Did setTexturePriorities get skipped? if (!tile) continue; |