summaryrefslogtreecommitdiffstats
path: root/cc/top_controls_manager_client.h
diff options
context:
space:
mode:
authoraelias@chromium.org <aelias@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-15 19:18:37 +0000
committeraelias@chromium.org <aelias@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-15 19:18:37 +0000
commitffb2720fcb361231b08b025af3d918e8533559d7 (patch)
tree1a3d42bf320a7f78c758dd1a571a129d11a16791 /cc/top_controls_manager_client.h
parente3aac6f355b4f0be75a6e22777775bbb064b9272 (diff)
downloadchromium_src-ffb2720fcb361231b08b025af3d918e8533559d7.zip
chromium_src-ffb2720fcb361231b08b025af3d918e8533559d7.tar.gz
chromium_src-ffb2720fcb361231b08b025af3d918e8533559d7.tar.bz2
Fix viewport and scrollbars for top-controls hiding.
1. Simplify top controls manager to never be in "overlay" mode, i.e. the top controls always push down the contents (note that the browser compositor is responsible for this; the renderer compositor just draws at the top of its surface and sends up the offset as metadata). 2. Introduce the concept of "visibleViewportSize". This is the true user-visible size on the current frame in DIP, not including top-controls or non-overlay scrollbars. This is used for max scroll bounds and scrollbar positioning. 3. Just disable clip layer masksToBounds if top controls are present, since it provides no value in the Android case. 4. Given the dynamism of the viewport size, abandon the WebKit scrollbar code and manually compute scrollbar quads after all. There are three inputs: trackRect (which is the layer size plus some margins); m_verticalAdjust which compensates for the fact the scrollbar layers are positioned by WebKit; and m_normalizedViewport which is a rect that encapsulates the position and size of both scrollbars. NOTRY=true BUG=161303 Review URL: https://chromiumcodereview.appspot.com/12519011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188445 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/top_controls_manager_client.h')
-rw-r--r--cc/top_controls_manager_client.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/cc/top_controls_manager_client.h b/cc/top_controls_manager_client.h
index f7b984a..e54aa4d 100644
--- a/cc/top_controls_manager_client.h
+++ b/cc/top_controls_manager_client.h
@@ -14,7 +14,6 @@ class CC_EXPORT TopControlsManagerClient {
virtual void setNeedsRedraw() = 0;
virtual void setActiveTreeNeedsUpdateDrawProperties() = 0;
virtual bool haveRootScrollLayer() const = 0;
- virtual float rootScrollLayerTotalScrollY() const = 0;
protected:
virtual ~TopControlsManagerClient() {}