summaryrefslogtreecommitdiffstats
path: root/cc/trees/layer_tree_host_common.h
diff options
context:
space:
mode:
authorenne <enne@chromium.org>2015-05-26 15:23:11 -0700
committerCommit bot <commit-bot@chromium.org>2015-05-26 22:23:46 +0000
commit6394d5b43b6327ff5ebcd17a41ad0919a390a406 (patch)
tree54fcac323b3aff34fd5ba7089673d69e1efd05cb /cc/trees/layer_tree_host_common.h
parent61d79b987a2337851520e25a8cd80f2f8859aece (diff)
downloadchromium_src-6394d5b43b6327ff5ebcd17a41ad0919a390a406.zip
chromium_src-6394d5b43b6327ff5ebcd17a41ad0919a390a406.tar.gz
chromium_src-6394d5b43b6327ff5ebcd17a41ad0919a390a406.tar.bz2
cc: Apply page scale to page scale layer
Currently, page scale is applied to children of the page scale layer but not to the page scale layer itself. This makes it cumbersome to update property trees during pinch zoom on the compositor thread, because the property tree needs to be searched for any nodes that use the page scale layer's node as a source node. In practice, from Blink, the page scale layer only has one child, but it's a layering violation to assume this. So, apply page scale to the target transform for the page scale layer itself. This shouldn't have any effect in practice, as the page scale layer doesn't usually have content. Also, clean up language that refers to both "page scale layer" and "page scale application layer". In CDP, these are the same thing, but in property tree land one is the parent and one is the child. Now there is only "page scale layer", which gets the page scale applied on it and to its children. This passes cc unit tests with main thread property tree verification manually hacked back on. R=ajuma@chromium.org, vollick@chromium.org, jdduke@chromium.org BUG=481585 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1144103003 Cr-Commit-Position: refs/heads/master@{#331451}
Diffstat (limited to 'cc/trees/layer_tree_host_common.h')
-rw-r--r--cc/trees/layer_tree_host_common.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/cc/trees/layer_tree_host_common.h b/cc/trees/layer_tree_host_common.h
index f1397d0..53ac758 100644
--- a/cc/trees/layer_tree_host_common.h
+++ b/cc/trees/layer_tree_host_common.h
@@ -39,7 +39,7 @@ class CC_EXPORT LayerTreeHostCommon {
const gfx::Transform& device_transform,
float device_scale_factor,
float page_scale_factor,
- const LayerType* page_scale_application_layer,
+ const LayerType* page_scale_layer,
const gfx::Vector2dF& elastic_overscroll,
const LayerType* elastic_overscroll_application_layer,
int max_texture_size,
@@ -56,7 +56,7 @@ class CC_EXPORT LayerTreeHostCommon {
device_transform(device_transform),
device_scale_factor(device_scale_factor),
page_scale_factor(page_scale_factor),
- page_scale_application_layer(page_scale_application_layer),
+ page_scale_layer(page_scale_layer),
elastic_overscroll(elastic_overscroll),
elastic_overscroll_application_layer(
elastic_overscroll_application_layer),
@@ -76,7 +76,7 @@ class CC_EXPORT LayerTreeHostCommon {
gfx::Transform device_transform;
float device_scale_factor;
float page_scale_factor;
- const LayerType* page_scale_application_layer;
+ const LayerType* page_scale_layer;
gfx::Vector2dF elastic_overscroll;
const LayerType* elastic_overscroll_application_layer;
int max_texture_size;