summaryrefslogtreecommitdiffstats
path: root/cc/trees/layer_tree_host_impl.cc
diff options
context:
space:
mode:
authordanakj <danakj@chromium.org>2015-10-20 16:05:24 -0700
committerCommit bot <commit-bot@chromium.org>2015-10-20 23:06:42 +0000
commita2fdbc70853e7b0cff492bd508f0d350d09c34b5 (patch)
treef39526e89d8fa6db30fe325031688716d43672dc /cc/trees/layer_tree_host_impl.cc
parentc87734f40b682207ff7b0989e769d08674f66008 (diff)
downloadchromium_src-a2fdbc70853e7b0cff492bd508f0d350d09c34b5.zip
chromium_src-a2fdbc70853e7b0cff492bd508f0d350d09c34b5.tar.gz
chromium_src-a2fdbc70853e7b0cff492bd508f0d350d09c34b5.tar.bz2
cc: Make conversions from gfx::Point to PointF explicit.
This implicit conversion operator will be going away. TBR=vmpstr BUG=342848 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1417003002 Cr-Commit-Position: refs/heads/master@{#355180}
Diffstat (limited to 'cc/trees/layer_tree_host_impl.cc')
-rw-r--r--cc/trees/layer_tree_host_impl.cc28
1 files changed, 16 insertions, 12 deletions
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 7bfe81b..98118cc 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -495,8 +495,8 @@ bool LayerTreeHostImpl::IsCurrentlyScrollingLayerAt(
if (!scrolling_layer_impl)
return false;
- gfx::PointF device_viewport_point =
- gfx::ScalePoint(viewport_point, active_tree_->device_scale_factor());
+ gfx::PointF device_viewport_point = gfx::ScalePoint(
+ gfx::PointF(viewport_point), active_tree_->device_scale_factor());
LayerImpl* layer_impl =
active_tree_->FindLayerThatIsHitByPoint(device_viewport_point);
@@ -524,8 +524,8 @@ bool LayerTreeHostImpl::IsCurrentlyScrollingLayerAt(
bool LayerTreeHostImpl::HaveWheelEventHandlersAt(
const gfx::Point& viewport_point) {
- gfx::PointF device_viewport_point =
- gfx::ScalePoint(viewport_point, active_tree_->device_scale_factor());
+ gfx::PointF device_viewport_point = gfx::ScalePoint(
+ gfx::PointF(viewport_point), active_tree_->device_scale_factor());
LayerImpl* layer_impl =
active_tree_->FindLayerWithWheelHandlerThatIsHitByPoint(
@@ -551,8 +551,8 @@ static ScrollBlocksOn EffectiveScrollBlocksOn(LayerImpl* layer) {
bool LayerTreeHostImpl::DoTouchEventsBlockScrollAt(
const gfx::Point& viewport_point) {
- gfx::PointF device_viewport_point =
- gfx::ScalePoint(viewport_point, active_tree_->device_scale_factor());
+ gfx::PointF device_viewport_point = gfx::ScalePoint(
+ gfx::PointF(viewport_point), active_tree_->device_scale_factor());
// First check if scrolling at this point is required to block on any
// touch event handlers. Note that we must start at the innermost layer
@@ -2469,8 +2469,8 @@ InputHandler::ScrollStatus LayerTreeHostImpl::ScrollBegin(
DCHECK(!CurrentlyScrollingLayer());
ClearCurrentlyScrollingLayer();
- gfx::PointF device_viewport_point =
- gfx::ScalePoint(viewport_point, active_tree_->device_scale_factor());
+ gfx::PointF device_viewport_point = gfx::ScalePoint(
+ gfx::PointF(viewport_point), active_tree_->device_scale_factor());
LayerImpl* layer_impl =
active_tree_->FindLayerThatIsHitByPoint(device_viewport_point);
@@ -2627,6 +2627,8 @@ static gfx::Vector2dF ScrollLayerWithLocalDelta(
return consumed_scroll;
}
+// TODO(danakj): Make this into two functions, one with delta, one with
+// viewport_point, no bool required.
gfx::Vector2dF LayerTreeHostImpl::ScrollLayer(LayerImpl* layer_impl,
const gfx::Vector2dF& delta,
const gfx::Point& viewport_point,
@@ -2638,8 +2640,10 @@ gfx::Vector2dF LayerTreeHostImpl::ScrollLayer(LayerImpl* layer_impl,
// screen (such as wheel events) represent a fixed amount of scrolling so we
// can just apply them directly, but the page scale factor is applied to the
// scroll delta.
- if (is_direct_manipulation)
- return ScrollLayerWithViewportSpaceDelta(layer_impl, viewport_point, delta);
+ if (is_direct_manipulation) {
+ return ScrollLayerWithViewportSpaceDelta(
+ layer_impl, gfx::PointF(viewport_point), delta);
+ }
float scale_factor = active_tree()->current_page_scale_factor();
return ScrollLayerWithLocalDelta(layer_impl, delta, scale_factor);
}
@@ -2870,8 +2874,8 @@ float LayerTreeHostImpl::DeviceSpaceDistanceToLayer(
}
void LayerTreeHostImpl::MouseMoveAt(const gfx::Point& viewport_point) {
- gfx::PointF device_viewport_point =
- gfx::ScalePoint(viewport_point, active_tree_->device_scale_factor());
+ gfx::PointF device_viewport_point = gfx::ScalePoint(
+ gfx::PointF(viewport_point), active_tree_->device_scale_factor());
LayerImpl* layer_impl =
active_tree_->FindLayerThatIsHitByPoint(device_viewport_point);
HandleMouseOverScrollbar(layer_impl);