diff options
| author | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-13 03:03:17 +0000 |
|---|---|---|
| committer | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-13 03:06:51 +0000 |
| commit | 4ea293f71923dd464e237f6ef581df22c625c695 (patch) | |
| tree | a05083f79e4dd6d69514f8ea17815fc5153de6cf /cc/trees/proxy.h | |
| parent | 4eebe74dc1fd6d3780180361f75707a6be33c3ce (diff) | |
| download | chromium_src-4ea293f71923dd464e237f6ef581df22c625c695.zip chromium_src-4ea293f71923dd464e237f6ef581df22c625c695.tar.gz chromium_src-4ea293f71923dd464e237f6ef581df22c625c695.tar.bz2 | |
Fix failing (flaky) LayerTreeHostTestLCDNotification test.
This test failed with impl-side painting because PictureLayer did not
skip commits caused by invalidating the layer during Update.
Meanwhile, this CL has some changes that changed the flaky failures
into always-failures. The change is to make the
ThreadProxy::CommitPendingForTesting check not only if a main frame is
in progress, but also if one will happen in the future. The failure was
flaky because the commit would be requested but not happen immediately
when impl-side painting was on due to activation (if the machine was
suitably loaded at the time). I renamed CommitPendingForTesting to
MainFrameWillHappenForTesting because "CommitPending" is a specific
notion in the public API of the scheduler and I didn't want to confuse
these two.
R=ajuma, brianderson, enne
BUG=402449, 397120
Review URL: https://codereview.chromium.org/462803002
Cr-Commit-Position: refs/heads/master@{#289165}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289165 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/trees/proxy.h')
| -rw-r--r-- | cc/trees/proxy.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cc/trees/proxy.h b/cc/trees/proxy.h index 6100562..112c259 100644 --- a/cc/trees/proxy.h +++ b/cc/trees/proxy.h @@ -101,7 +101,7 @@ class CC_EXPORT Proxy { virtual void SetDebugState(const LayerTreeDebugState& debug_state) = 0; // Testing hooks - virtual bool CommitPendingForTesting() = 0; + virtual bool MainFrameWillHappenForTesting() = 0; protected: Proxy(scoped_refptr<base::SingleThreadTaskRunner> main_task_runner, |