diff options
author | ernstm@chromium.org <ernstm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-15 23:33:29 +0000 |
---|---|---|
committer | ernstm@chromium.org <ernstm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-15 23:33:29 +0000 |
commit | 5c6739c1645ebbd84bb1e39c09a6fd12d4d0256d (patch) | |
tree | e0fcba5345cc770a671b5cca4ac42153354b3204 /cc/trees | |
parent | b614d2e4a14684973b534043d52651410bed6c2b (diff) | |
download | chromium_src-5c6739c1645ebbd84bb1e39c09a6fd12d4d0256d.zip chromium_src-5c6739c1645ebbd84bb1e39c09a6fd12d4d0256d.tar.gz chromium_src-5c6739c1645ebbd84bb1e39c09a6fd12d4d0256d.tar.bz2 |
cc: Increased robustness of rasterize and record benchmark.
- 'protected' relevent trace events from changes, by putting argument strings
as constants into separate file.
- fixed a bug in the collection of raster times, that would output wrong
statistics for layers with multiple pictures in a pile.
- Added command line parameters to set number of raster and record repeats,
wait time before starting the benchmark, and wait time before taking the
measurements.
- Reduced the default number of raster and record repeats from 100 to 20.
This increases variance, but improves overall robustness (e.g. avoiding
event buffer overflows)
- Added command line option to print statistics after every page run.
R=nduca@chromium.org,tengs@chromium.org
BUG=226489
Review URL: https://chromiumcodereview.appspot.com/18048006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211728 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/trees')
-rw-r--r-- | cc/trees/layer_tree_host.cc | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/cc/trees/layer_tree_host.cc b/cc/trees/layer_tree_host.cc index af751dd..a4ff570 100644 --- a/cc/trees/layer_tree_host.cc +++ b/cc/trees/layer_tree_host.cc @@ -17,6 +17,7 @@ #include "cc/animation/animation_registrar.h" #include "cc/animation/layer_animation_controller.h" #include "cc/base/math_util.h" +#include "cc/debug/benchmark_instrumentation.h" #include "cc/debug/overdraw_metrics.h" #include "cc/debug/rendering_stats_instrumentation.h" #include "cc/input/top_controls_manager.h" @@ -690,10 +691,10 @@ bool LayerTreeHost::UsingSharedMemoryResources() { bool LayerTreeHost::UpdateLayers(Layer* root_layer, ResourceUpdateQueue* queue) { - // If you change the name of this event or its arguments, please update - // tools/perf/perf_tools/rasterize_and_record_benchmark.py as well. - TRACE_EVENT1("cc", "LayerTreeHost::UpdateLayers", - "SourceFrameNumber", commit_number()); + TRACE_EVENT1(benchmark_instrumentation::kCategory, + benchmark_instrumentation::kLayerTreeHostUpdateLayers, + benchmark_instrumentation::kCommitNumber, + commit_number()); LayerList update_list; { |