summaryrefslogtreecommitdiffstats
path: root/cc
diff options
context:
space:
mode:
authormpearson@chromium.org <mpearson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-07-28 17:55:00 +0000
committermpearson@chromium.org <mpearson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-07-28 17:55:00 +0000
commitf7efe5e16454fffac843b8008799e0927db511c4 (patch)
tree57dcd5ab2b46ec63751bf5aac1ec79d66cb3593e /cc
parente56131d203ae5bc79de9c9285a63c0b107aed5e9 (diff)
downloadchromium_src-f7efe5e16454fffac843b8008799e0927db511c4.zip
chromium_src-f7efe5e16454fffac843b8008799e0927db511c4.tar.gz
chromium_src-f7efe5e16454fffac843b8008799e0927db511c4.tar.bz2
Newly re-enable test fails consistently on the Win 7 bots
http://build.chromium.org/p/chromium.win/waterfall?builder=Win%207%20Tests%20x64%20(1) LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets: [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(180)] Percentage of pixels with an error: 6.49 [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(182)] Percentage of pixels with errors not greater than 0: 0 [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(185)] Average absolute error (excluding identical pixels): R=0.990755 G=0.503852 B=0.990755 A=0 [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(190)] Largest absolute error: R=2 G=2 B=2 A=0 [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=12 y=184; actual RGBA=(130,192,130,0); expected RGBA=(129,192,129,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=15; actual RGBA=(144,200,144,0); expected RGBA=(143,199,143,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=16; actual RGBA=(152,204,152,0); expected RGBA=(151,203,151,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=17; actual RGBA=(159,207,159,0); expected RGBA=(158,206,158,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=18; actual RGBA=(165,210,165,0); expected RGBA=(164,209,164,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=19; actual RGBA=(169,212,169,0); expected RGBA=(168,211,168,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=20; actual RGBA=(172,213,172,0); expected RGBA=(171,212,171,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=21; actual RGBA=(174,215,174,0); expected RGBA=(173,214,173,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=22; actual RGBA=(175,215,175,0); expected RGBA=(174,214,174,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=23; actual RGBA=(176,216,176,0); expected RGBA=(175,214,175,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=24; actual RGBA=(177,216,177,0); expected RGBA=(176,215,176,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=25; actual RGBA=(177,216,177,0); expected RGBA=(176,215,176,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=26; actual RGBA=(177,216,177,0); expected RGBA=(176,215,176,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=27; actual RGBA=(177,216,177,0); expected RGBA=(176,215,176,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=28; actual RGBA=(177,216,177,0); expected RGBA=(176,215,176,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=29; actual RGBA=(177,216,177,0); expected RGBA=(176,215,176,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=30; actual RGBA=(177,216,177,0); expected RGBA=(176,215,176,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=31; actual RGBA=(177,216,177,0); expected RGBA=(176,215,176,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=32; actual RGBA=(177,216,177,0); expected RGBA=(176,215,176,0) [2996:3920:0728/095913:3045950:ERROR:pixel_comparator.cc(205)] Pixel error at x=13 y=33; actual RGBA=(177,216,177,0); expected RGBA=(176,215,176,0) ... Revert 214098 "Re-enable cc_unittest LayerTreeHostFiltersPixelTe..." > Re-enable cc_unittest LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets, and adjust the fuzzy match threshold on Windows. > > R=danakj > BUG= > > Review URL: https://chromiumcodereview.appspot.com/20542002 TBR=senorblanco@chromium.org Review URL: https://codereview.chromium.org/20972002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214131 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc')
-rw-r--r--cc/trees/layer_tree_host_pixeltest_filters.cc6
1 files changed, 3 insertions, 3 deletions
diff --git a/cc/trees/layer_tree_host_pixeltest_filters.cc b/cc/trees/layer_tree_host_pixeltest_filters.cc
index 9310029..553e66e 100644
--- a/cc/trees/layer_tree_host_pixeltest_filters.cc
+++ b/cc/trees/layer_tree_host_pixeltest_filters.cc
@@ -52,7 +52,7 @@ TEST_F(LayerTreeHostFiltersPixelTest, BackgroundFilterBlur) {
base::FilePath(FILE_PATH_LITERAL("background_filter_blur.png")));
}
-TEST_F(LayerTreeHostFiltersPixelTest, BackgroundFilterBlurOutsets) {
+TEST_F(LayerTreeHostFiltersPixelTest, DISABLED_BackgroundFilterBlurOutsets) {
scoped_refptr<SolidColorLayer> background = CreateSolidColorLayer(
gfx::Rect(200, 200), SK_ColorWHITE);
@@ -73,8 +73,8 @@ TEST_F(LayerTreeHostFiltersPixelTest, BackgroundFilterBlurOutsets) {
blur->SetBackgroundFilters(filters);
#if defined(OS_WIN)
- // Windows has 2596 pixels off by at most 2: crbug.com/259922
- float percentage_pixels_large_error = 6.49f; // 2596px / (200*200)
+ // Windows has 2250 pixels off by at most 2: crbug.com/259922
+ float percentage_pixels_large_error = 5.625f; // 2250px / (200*200)
float percentage_pixels_small_error = 0.0f;
float average_error_allowed_in_bad_pixels = 1.f;
int large_error_allowed = 2;