diff options
| author | Brett Wilson <brettw@chromium.org> | 2014-09-11 10:19:19 -0700 |
|---|---|---|
| committer | Brett Wilson <brettw@chromium.org> | 2014-09-11 18:31:28 +0000 |
| commit | 19b5fdba953c49a1a20003726ca719b00df14f20 (patch) | |
| tree | 0c4a44e1caccd2acf8c081046ce0ac7050e0b5c6 /chrome/BUILD.gn | |
| parent | b62471bd51803999f8f70f00a2bfd63991a7b9d9 (diff) | |
| download | chromium_src-19b5fdba953c49a1a20003726ca719b00df14f20.zip chromium_src-19b5fdba953c49a1a20003726ca719b00df14f20.tar.gz chromium_src-19b5fdba953c49a1a20003726ca719b00df14f20.tar.bz2 | |
Convert GN visibility to be a list.
GN visibility currently allows either string or list types, but this is causing
some problems for some templates, which don't know if the invoker set the
visibility to a list or a string. Since there is no type reflection, templates
don't know how to handle visibility if they need to add to or replace the list.
Adds a missing error check in the config visibility checker.
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/552843005
Cr-Commit-Position: refs/heads/master@{#294411}
Diffstat (limited to 'chrome/BUILD.gn')
| -rw-r--r-- | chrome/BUILD.gn | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn index 554f91d..ba69e8f 100644 --- a/chrome/BUILD.gn +++ b/chrome/BUILD.gn @@ -242,7 +242,7 @@ if (is_win) { process_version("version_header") { # TODO(brettW) this should have more reduced visibility, but chrome/browser # currently depends on this. - #visibility = ":*" + #visibility = [ ":*" ] source = "version.h.in" # TODO(brettw) this should move to $target_gen_dir/version.h and # source files including it should reference it via "chrome/version.h" @@ -397,7 +397,7 @@ repack("packed_extra_resources") { # Collects per-locale grit files from many sources into global per-locale files. chrome_repack_locales("repack_locales_pack") { - visibility = ":*" + visibility = [ ":*" ] input_locales = locales @@ -409,7 +409,7 @@ chrome_repack_locales("repack_locales_pack") { } chrome_repack_locales("repack_pseudo_locales_pack") { - visibility = ":*" + visibility = [ ":*" ] input_locales = [ "fake-bidi" ] @@ -442,7 +442,7 @@ template("chrome_repack_percent") { copy_name = target_name repack(repack_name) { - visibility = ":$copy_name" + visibility = [ ":$copy_name" ] # All sources should also have deps for completeness. sources = [ "$root_gen_dir/components/resources/component_resources_${percent}_percent.pak", @@ -490,7 +490,7 @@ template("chrome_repack_percent") { } copy(copy_name) { - visibility = ":*" + visibility = [ ":*" ] deps = [ ":$repack_name" ] sources = [ repack_output_file ] outputs = [ "$root_build_dir/chrome_${percent}_percent.pak" ] |