diff options
| author | mathp <mathp@chromium.org> | 2015-10-21 13:53:57 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-21 20:54:55 +0000 |
| commit | 43a8e38f6318192b107626d74e75c90d8d99f885 (patch) | |
| tree | 09fe7f149029bfcab72be64b9a2a992047b53d8f /chrome/BUILD.gn | |
| parent | dd1274f99b889df2a344ddf64143a307d5a67d48 (diff) | |
| download | chromium_src-43a8e38f6318192b107626d74e75c90d8d99f885.zip chromium_src-43a8e38f6318192b107626d74e75c90d8d99f885.tar.gz chromium_src-43a8e38f6318192b107626d74e75c90d8d99f885.tar.bz2 | |
Revert of Cleanup chrome/version.h handling (patchset #9 id:160001 of https://codereview.chromium.org/1405633002/ )
Reason for revert:
Causing failures on the GN build (not gyp) for Mac:
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/23191
Original issue's description:
> Cleanup chrome/common/chrome_version.h handling
>
> Rename "version.h" to "chrome/common/chrome_version.h"
> Update #include and GYP/GN references
> Generate on all platforms
> Remove redundant generated chrome/common/chrome_version.cc.version
> Fix DEPS include_rules
>
> BUG=542807
>
> Committed: https://crrev.com/59647ecac9524d954010d3d10b539ee4a340bf94
> Cr-Commit-Position: refs/heads/master@{#355196}
>
> Committed: https://crrev.com/31f086c2013853749cac45522eb950b9d0ab0302
> Cr-Commit-Position: refs/heads/master@{#355377}
TBR=brettw@chromium.org,mdempsky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=542807
Review URL: https://codereview.chromium.org/1418933002
Cr-Commit-Position: refs/heads/master@{#355393}
Diffstat (limited to 'chrome/BUILD.gn')
| -rw-r--r-- | chrome/BUILD.gn | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn index 4693d6c..67431e3 100644 --- a/chrome/BUILD.gn +++ b/chrome/BUILD.gn @@ -425,6 +425,22 @@ group("child_dependencies") { } if (is_win) { + # TODO(brettw) this duplicates "//chrome/common:version" which applies to + # Linux. + process_version("version_header") { + # TODO(brettW) this should have more reduced visibility, but chrome/browser + # currently depends on this. + #visibility = [ ":*" ] + + # This one just uses the custom template and no separate sources. + sources = [] + template_file = "version.h.in" + + # TODO(brettw) this should move to $target_gen_dir/version.h and + # source files including it should reference it via "chrome/version.h" + output = "$root_gen_dir/version.h" + } + process_version("chrome_exe_version") { template_file = chrome_version_rc_template sources = [ |