Implement temporary First Run Dialog on OS X

We use a modal dialog with a single checkbox on OS X.

We use the OSX defaults system since we want something quick and reliable.  The
dialog is displayed at a very early stage in Chrome startup (Before any
subsystems start relying on the stats variable).  This means there are a few
quirks in displaying the UI.

A change was also needed to our event handling code since when the dialog is
shown we spin an event loop at a very early stage in the process lifetime.

Changed default value for stats to false and updated unit tests to reflect that.

Also some misc. minor cleanup.

BUG=11971,12046

Review URL: http://codereview.chromium.org/115608

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16669 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 0 deletions

diff --git a/chrome/app/breakpad_mac.mm b/chrome/app/breakpad_mac.mm
index 28afe27..9155e29 100644
--- a/chrome/app/breakpad_mac.mm
+++ b/chrome/app/breakpad_mac.mm
@@ -16,6 +16,9 @@
 #include "chrome/installer/util/google_update_settings.h"
 
 #if !defined(GOOGLE_CHROME_BUILD)
+
+extern "C" {
+
 // If we aren't compiling as a branded build, then add dummy versions of the
 // Breakpad functions so we don't have to link against Breakpad.
 
@@ -36,6 +39,8 @@ void BreakpadRemoveKeyValue(BreakpadRef ref, NSString *key) {
   NOTREACHED();
 }
 
+}
+
 #endif  // !defined(GOOGLE_CHROME_BUILD)
 
 namespace {