diff options
| author | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-09 00:11:45 +0000 |
|---|---|---|
| committer | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-09 00:11:45 +0000 |
| commit | d2e34d8219af1f8fa315455f41e98d8f7c498555 (patch) | |
| tree | 870125905094025d47a6c234621e06d845c83469 /chrome/app/theme/ash/browser_reload_hot.png | |
| parent | 166f20ff846640059ddd7431a5a8ef93df09f4fe (diff) | |
| download | chromium_src-d2e34d8219af1f8fa315455f41e98d8f7c498555.zip chromium_src-d2e34d8219af1f8fa315455f41e98d8f7c498555.tar.gz chromium_src-d2e34d8219af1f8fa315455f41e98d8f7c498555.tar.bz2 | |
cros: Fix theme window frames to not paint transparent
We were painting the theme frame image with transparency, which made it almost invisible in solo-window mode, then painting the theme overlay fully opaque. This lead to incorrect rendering of many themes. We now follow the pattern we use for Windows Aero glass - all theme images are drawn fully opaque.
Also, some themes don't supply inactive versions of their theme_frame image, and rely on the theme pack to generate one from the active image. This interfered with a hack I was doing to override the IDR_THEME_FRAME_INACTIVE ID where there wasn't a custom image supplied. I got rid of the hack and we now use the canonical IDR_THEME_FRAME_* resource IDs on Ash and I updated the default assets the version we're using.
We should probably backport this to R20, since it's a regression in theme painting and the fix is small and safe.
BUG=124095
TEST=Added FramePainterTest.GetHeaderOpacity().
R=derat@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10310065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135951 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app/theme/ash/browser_reload_hot.png')
0 files changed, 0 insertions, 0 deletions