diff options
| author | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-16 20:36:29 +0000 |
|---|---|---|
| committer | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-16 20:36:29 +0000 |
| commit | cef1f457eaf6728df2860519a13136ec4ccf9bff (patch) | |
| tree | 264498e8781356a1bdf916bbb6c2d32e3149577f /chrome/app | |
| parent | 2ad0805505af0290438cf8fe39c2e8258f87616a (diff) | |
| download | chromium_src-cef1f457eaf6728df2860519a13136ec4ccf9bff.zip chromium_src-cef1f457eaf6728df2860519a13136ec4ccf9bff.tar.gz chromium_src-cef1f457eaf6728df2860519a13136ec4ccf9bff.tar.bz2 | |
Fix problem of identical search engine logos + names in search engine dialog.
After discussion with Brian and the search engine group for EMEA, the decision was made to fix by adding the distinct logo for Yahoo, in the case of Canada, and allowing Bing to be represented by one search engine out of the three in the Arab states and BE. Because Bing, like Google, does not use distinct logos for different locales, and allows users to change language easily from the home page (based on market area), we treat Bing like Google, and have it represented by only a single search engine in the dialog of three choices.
The Search Engine Dialog is populated by the top three search engines in the template_url_prepopulate_data.cc for each country, so to make this change, we move the second Bing language search engine out from the third into the fourth position. Thus both will still be available in the user's "manage search engines" options, but only one will appear in the dialog.
BUG=51224
TEST=Search engine dialog has three separate search engines for each country -- especially BE, CA, DZ, MA, SY.
Review URL: http://codereview.chromium.org/3110016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56223 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/app')
| -rw-r--r-- | chrome/app/theme/theme_resources.grd | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/app/theme/theme_resources.grd b/chrome/app/theme/theme_resources.grd index ebcd87a..080d9f9 100644 --- a/chrome/app/theme/theme_resources.grd +++ b/chrome/app/theme/theme_resources.grd @@ -295,6 +295,7 @@ <include name="IDR_SEARCH_ENGINE_LOGO_WALLA" file="google_chrome/search_walla.png" type="BINDATA" /> <include name="IDR_SEARCH_ENGINE_LOGO_YAHOO" file="google_chrome/search_yahoo.png" type="BINDATA" /> <include name="IDR_SEARCH_ENGINE_LOGO_YAHOOJP" file="google_chrome/search_yahoojp.png" type="BINDATA" /> + <include name="IDR_SEARCH_ENGINE_LOGO_YAHOOQC" file="google_chrome/search_yahooqc.png" type="BINDATA" /> <include name="IDR_SEARCH_ENGINE_LOGO_YANDEX" file="google_chrome/search_yandex.png" type="BINDATA" /> <include name="IDR_SEARCH_ENGINE_LOGO_ZOZNAM" file="google_chrome/search_zoznam.png" type="BINDATA" /> </if> @@ -327,6 +328,7 @@ <include name="IDR_SEARCH_ENGINE_LOGO_WALLA" file="notused.png" type="BINDATA" /> <include name="IDR_SEARCH_ENGINE_LOGO_YAHOO" file="notused.png" type="BINDATA" /> <include name="IDR_SEARCH_ENGINE_LOGO_YAHOOJP" file="notused.png" type="BINDATA" /> + <include name="IDR_SEARCH_ENGINE_LOGO_YAHOOQC" file="notused.png" type="BINDATA" /> <include name="IDR_SEARCH_ENGINE_LOGO_YANDEX" file="notused.png" type="BINDATA" /> <include name="IDR_SEARCH_ENGINE_LOGO_ZOZNAM" file="notused.png" type="BINDATA" /> </if> |