diff options
author | estade <estade@chromium.org> | 2015-04-28 11:07:42 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-04-28 18:08:35 +0000 |
commit | b5efbab6f71b0e2660e3d5231d99df698c0e5b38 (patch) | |
tree | 4a6ddaebaeec6b83fef16a36f5fa85fe7a81e038 /chrome/browser/about_flags.cc | |
parent | 51689d131ef4401d3349684ab466e666469f2c7e (diff) | |
download | chromium_src-b5efbab6f71b0e2660e3d5231d99df698c0e5b38.zip chromium_src-b5efbab6f71b0e2660e3d5231d99df698c0e5b38.tar.gz chromium_src-b5efbab6f71b0e2660e3d5231d99df698c0e5b38.tar.bz2 |
Android - Introduce "keyboard accessory" for Autofill suggestions.
The new UI is exposed behind a flag, --enable-autofill-keyboard-accessory-view. The intent is that there should be no behavior change when the flag is not passed, but eventually the flag will become the default and AutofillPopup[Bridge] and related code will be removed.
This maintains the same appearance for the list items, and matching the mocks (switching to white on blue, etc.) is a TODO. See go/wzhwq for goal state.
There are also TODOs surrounding behavior:
- we likely want to hide the keyboard accessory if the keyboard hide
- add animations
- somehow deal with very small amounts of available space (comes up in landscape mode)
BUG=428087
TBR=isherman@chromium.org
Review URL: https://codereview.chromium.org/1082183002
Cr-Commit-Position: refs/heads/master@{#327324}
Diffstat (limited to 'chrome/browser/about_flags.cc')
-rw-r--r-- | chrome/browser/about_flags.cc | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc index 9aae179..9596ea5 100644 --- a/chrome/browser/about_flags.cc +++ b/chrome/browser/about_flags.cc @@ -2396,6 +2396,15 @@ const Experiment kExperiments[] = { kOsAndroid | kOsMac | kOsWin | kOsLinux | kOsCrOS, MULTI_VALUE_TYPE(kSupervisedUserSafeSitesChoices) }, +#if defined(OS_ANDROID) + { + "enable-autofill-keyboard-accessory-view", + IDS_FLAGS_AUTOFILL_ACCESSORY_VIEW_NAME, + IDS_FLAGS_AUTOFILL_ACCESSORY_VIEW_DESCRIPTION, + kOsAndroid, + SINGLE_VALUE_TYPE(autofill::switches::kEnableAccessorySuggestionView) + }, +#endif // defined(OS_ANDROID) // NOTE: Adding new command-line switches requires adding corresponding // entries to enum "LoginCustomFlags" in histograms.xml. See note in // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. |