diff options
| author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-23 19:33:26 +0000 |
|---|---|---|
| committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-23 19:33:26 +0000 |
| commit | aa4d9e4710dca9f41f2fcea256b996421b10912f (patch) | |
| tree | 13c509800a7ef9d53a0d3c69f0d5375583ccc87a /chrome/browser/accessibility | |
| parent | d8542e8f5aa58387ba148606d55f7b8e078a60f5 (diff) | |
| download | chromium_src-aa4d9e4710dca9f41f2fcea256b996421b10912f.zip chromium_src-aa4d9e4710dca9f41f2fcea256b996421b10912f.tar.gz chromium_src-aa4d9e4710dca9f41f2fcea256b996421b10912f.tar.bz2 | |
Re-reland Propagate OnNativeWidgetMove to delegate/observers, etc.
Continuation of reverted CL http://codereview.chromium.org/10025039
Relanding this patch exposed a new issues on cros:
1) KioskModeTest.EnableKioskModeTest fails (did unrelated cleanup).
2) Some bubbles crash OnWidgetMove (make |move_with_anchor_| opt-in).
3) Some bubbles crash OnWidgetClosing (cache |anchor_widget_|).
2nd patch description:
Continuation of reverted CL http://codereview.chromium.org/10021029
The original CL was reverted due to a naming conflict between:
WidgetDelegate::OnWidgetMove and Widget::Observer::OnWidgetMove.
I renamed the new Observer method to OnWidgetMoved.
Original description:
Propagate OnNativeWidgetMove to delegate/observers, etc.
NativeWidget[Aura|Win] calls new Widget::OnNativeWidgetMove.
Widgets alert delegates and new Widget::Observer::OnWidgetMove.
TabDragController2: consume new observer method, simplify.
Nix BrowserWindowMoveObserver; use Widget::Observer instead.
Replace move_loop_browser_view_ with move_loop_widget.
Replace GetAttachedBrowserView with GetAttachedBrowserWidget.
BubbleDelegateView: consume new observer method.
Make bubbles move with their anchor_view's Widgets.
SchedulePaint on BubbleFrameView when mirroring its arrow.
BUG=105151,116336,124310,124324,124352,chromium-os:29747
TEST=Bubbles can move with the browser window (inspecting extension popups, etc.); no Ash / --enable-tab-browser-dragging regressions.
Review URL: http://codereview.chromium.org/10162017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133495 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/accessibility')
| -rw-r--r-- | chrome/browser/accessibility/invert_bubble_views.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/accessibility/invert_bubble_views.cc b/chrome/browser/accessibility/invert_bubble_views.cc index 970d8eb..b313d26 100644 --- a/chrome/browser/accessibility/invert_bubble_views.cc +++ b/chrome/browser/accessibility/invert_bubble_views.cc @@ -82,6 +82,7 @@ void InvertBubbleView::Init() { // user to close it explicitly, which should be okay because it affects // a small minority of users, and only once. set_close_on_deactivate(false); + set_move_with_anchor(true); } gfx::Rect InvertBubbleView::GetAnchorRect() { |