diff options
| author | kaznacheev@chromium.org <kaznacheev@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-21 22:14:59 +0000 |
|---|---|---|
| committer | kaznacheev@chromium.org <kaznacheev@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-21 22:14:59 +0000 |
| commit | 8ee610354614da5dd5f14081e840dc485ac7699f (patch) | |
| tree | 42bf6dd62e88766d320a26e39acbb5d99b1a5984 /chrome/browser/android/tab_android.h | |
| parent | d51245a1b22d127b0a16e581221aee591d808ab8 (diff) | |
| download | chromium_src-8ee610354614da5dd5f14081e840dc485ac7699f.zip chromium_src-8ee610354614da5dd5f14081e840dc485ac7699f.tar.gz chromium_src-8ee610354614da5dd5f14081e840dc485ac7699f.tar.bz2 | |
DevTools: Make Android tabs unloaded from memory accessible via remote debugging protocol (3/3)
Step 3 out of 3:
- Implemented GetTitle, GetURL and RestoreIfNeeded in TabAndroid.h/.cc and TabBase.java
- Removed tab id parameter from TabBase#nativeInitWebContents
- Introduced a new DevToolsTarget implementation for an unloaded tab (relying on the new TabAndroid methods)
- Changed DevToolsServerDelegate to enumerate all tabs (including unloaded)
- Cleaned up after Step 1:
-- Made the new methods in TabModel pure
-- Removed the bridge method TabAndroid::InitWebContents with the old signature.
-- Removed TabAndroid::android_id()
BUG=272174
Review URL: https://codereview.chromium.org/25627004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229934 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/android/tab_android.h')
| -rw-r--r-- | chrome/browser/android/tab_android.h | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/chrome/browser/android/tab_android.h b/chrome/browser/android/tab_android.h index 45c6401..31e3266 100644 --- a/chrome/browser/android/tab_android.h +++ b/chrome/browser/android/tab_android.h @@ -57,8 +57,15 @@ class TabAndroid : public CoreTabHelperDelegate, // Return specific id information regarding this TabAndroid. const SessionID& session_id() const { return session_tab_id_; } int GetAndroidId() const; - // TODO(kaznacheev) Remove when there are no more downstream usages. - int android_id() const { return GetAndroidId(); } + + // Return the tab title. + string16 GetTitle() const; + + // Return the tab url. + GURL GetURL() const; + + // Restore the tab if it was unloaded from memory. + bool RestoreIfNeeded(); // Helper methods to make it easier to access objects from the associated // WebContents. Can return NULL. @@ -123,13 +130,6 @@ class TabAndroid : public CoreTabHelperDelegate, // Methods called from Java via JNI ----------------------------------------- - // TODO(kaznacheev) Remove when there are no more downstream usages. - virtual void InitWebContents(JNIEnv* env, - jobject obj, - jint tab_id, - jboolean incognito, - jobject jcontent_view_core, - jobject jweb_contents_delegate); virtual void InitWebContents(JNIEnv* env, jobject obj, jboolean incognito, |