diff options
| author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-27 22:57:40 +0000 |
|---|---|---|
| committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-27 22:57:40 +0000 |
| commit | 5d9829491fa187db0fbbecb7f1e139d8367dcc16 (patch) | |
| tree | 641f14f9285abae645efbb67da4cb378736f4e22 /chrome/browser/app_controller_mac.mm | |
| parent | b61a5d8a9a3eb306079743e73f592a6ac6c8c8b3 (diff) | |
| download | chromium_src-5d9829491fa187db0fbbecb7f1e139d8367dcc16.zip chromium_src-5d9829491fa187db0fbbecb7f1e139d8367dcc16.tar.gz chromium_src-5d9829491fa187db0fbbecb7f1e139d8367dcc16.tar.bz2 | |
Moves command handling from Browser to a new object, BrowserCommandController.
Notes:
. BrowserCommandController now owns the CommandUpdater.
. CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller.
. The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward.
. Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands.
http://crbug.com/133576
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10677009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144597 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/app_controller_mac.mm')
| -rw-r--r-- | chrome/browser/app_controller_mac.mm | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm index be7af30..c5f9293 100644 --- a/chrome/browser/app_controller_mac.mm +++ b/chrome/browser/app_controller_mac.mm @@ -827,7 +827,7 @@ const AEEventClass kAECloudPrintUninstallClass = 'GCPu'; // Create a new tab in an existing browser window (which we activate) if // possible. if (Browser* browser = ActivateBrowser(lastProfile)) { - browser->ExecuteCommand(IDC_NEW_TAB); + chrome::ExecuteCommand(browser, IDC_NEW_TAB); break; } // Else fall through to create new window. @@ -835,10 +835,12 @@ const AEEventClass kAECloudPrintUninstallClass = 'GCPu'; CreateBrowser(lastProfile); break; case IDC_FOCUS_LOCATION: - ActivateOrCreateBrowser(lastProfile)->ExecuteCommand(IDC_FOCUS_LOCATION); + chrome::ExecuteCommand(ActivateOrCreateBrowser(lastProfile), + IDC_FOCUS_LOCATION); break; case IDC_FOCUS_SEARCH: - ActivateOrCreateBrowser(lastProfile)->ExecuteCommand(IDC_FOCUS_SEARCH); + chrome::ExecuteCommand(ActivateOrCreateBrowser(lastProfile), + IDC_FOCUS_SEARCH); break; case IDC_NEW_INCOGNITO_WINDOW: CreateBrowser(lastProfile->GetOffTheRecordProfile()); @@ -847,7 +849,7 @@ const AEEventClass kAECloudPrintUninstallClass = 'GCPu'; chrome::OpenWindowWithRestoredTabs(lastProfile); break; case IDC_OPEN_FILE: - CreateBrowser(lastProfile)->ExecuteCommand(IDC_OPEN_FILE); + chrome::ExecuteCommand(CreateBrowser(lastProfile), IDC_OPEN_FILE); break; case IDC_CLEAR_BROWSING_DATA: { // There may not be a browser open, so use the default profile. |