diff options
| author | rpaquay@chromium.org <rpaquay@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-03 02:51:21 +0000 |
|---|---|---|
| committer | rpaquay@chromium.org <rpaquay@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-03 02:51:21 +0000 |
| commit | 15d812579c5defae909b07b0dd5fd0d7dbc30b0e (patch) | |
| tree | 4f94146839581aea377d179a2010166370b94b1d /chrome/browser/apps/drive | |
| parent | ca42737d5bba6f7f40e4ab85e408e65f2371232e (diff) | |
| download | chromium_src-15d812579c5defae909b07b0dd5fd0d7dbc30b0e.zip chromium_src-15d812579c5defae909b07b0dd5fd0d7dbc30b0e.tar.gz chromium_src-15d812579c5defae909b07b0dd5fd0d7dbc30b0e.tar.bz2 | |
Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.
The intent is to be able to address issues found in https://code.google.com/p/chromium/issues/detail?id=84556#c39
* This change should be a strict refactoring, and there should be no change of behavior wrt to extension uninstall behavior.
* Identify a few specific reasons for extension uninstall and create enum values for them.
* Run "git cl format"
BUG=84556
TBR=sky@chromium.org for trivial changes under chrome/browser, except chrome/browser/extensions (already lgtm'ed).
Review URL: https://codereview.chromium.org/284103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281130 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/apps/drive')
| -rw-r--r-- | chrome/browser/apps/drive/drive_app_provider.cc | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/chrome/browser/apps/drive/drive_app_provider.cc b/chrome/browser/apps/drive/drive_app_provider.cc index 2bde9fe..3aeb5a0 100644 --- a/chrome/browser/apps/drive/drive_app_provider.cc +++ b/chrome/browser/apps/drive/drive_app_provider.cc @@ -82,7 +82,9 @@ void DriveAppProvider::UpdateMappingAndExtensionSystem( if (existing_app && is_existing_app_generated) { extensions::ExtensionSystem::Get(profile_) ->extension_service() - ->UninstallExtension(existing_chrome_app_id, false, NULL); + ->UninstallExtension(existing_chrome_app_id, + ExtensionService::UNINSTALL_REASON_SYNC, + NULL); } } @@ -191,7 +193,8 @@ void DriveAppProvider::ProcessRemovedDriveApp(const std::string& drive_app_id) { extensions::ExtensionSystem::Get(profile_) ->extension_service() - ->UninstallExtension(chrome_app_id, false, NULL); + ->UninstallExtension( + chrome_app_id, ExtensionService::UNINSTALL_REASON_SYNC, NULL); } void DriveAppProvider::OnDriveAppRegistryUpdated() { |