diff options
| author | mrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-15 18:51:16 +0000 |
|---|---|---|
| committer | mrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-15 18:51:16 +0000 |
| commit | 0822d88ca6c5451ab3553cca1a603ebfc575dc40 (patch) | |
| tree | 41f8667ff00a0027c3bca91cbeedfe88fe7157d8 /chrome/browser/autocomplete/autocomplete.cc | |
| parent | f941f47a837bc6d98937acc6a13603bb7c06d286 (diff) | |
| download | chromium_src-0822d88ca6c5451ab3553cca1a603ebfc575dc40.zip chromium_src-0822d88ca6c5451ab3553cca1a603ebfc575dc40.tar.gz chromium_src-0822d88ca6c5451ab3553cca1a603ebfc575dc40.tar.bz2 | |
HQP Refactoring (in Preparation for SQLite Cache)
1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs.
2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData.
3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available.
4. Correctly handle the adding and removing of page title words when a URL change is detected.
5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h.
6. Replace static class member functions with non-friend, non-class functions for better flexibility.
7. Move convenience types out from InMemoryURLIndex class up into history namespace.
8. Rename convenience types to generalize their intent.
9. Other small cleanups.
BUG=96731, 92718
TEST=Unit tests updated.
TBR=atwilson,brettw
Previously reviewed and LG'ed as http://codereview.chromium.org/8120004/.
Review URL: http://codereview.chromium.org/8291005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105678 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete/autocomplete.cc')
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/browser/autocomplete/autocomplete.cc b/chrome/browser/autocomplete/autocomplete.cc index 6dbb9a1..8b6618c 100644 --- a/chrome/browser/autocomplete/autocomplete.cc +++ b/chrome/browser/autocomplete/autocomplete.cc @@ -531,6 +531,8 @@ void AutocompleteProvider::Stop() { } void AutocompleteProvider::DeleteMatch(const AutocompleteMatch& match) { + DLOG(WARNING) << "The AutocompleteProvider '" << name() + << "' has not implemented DeleteMatch."; } AutocompleteProvider::~AutocompleteProvider() { |