summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete/autocomplete_input.cc
diff options
context:
space:
mode:
authormukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-20 16:56:03 +0000
committermukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-20 16:56:03 +0000
commit332d17d2d2889750fd87da90c2d9a796163e981c (patch)
tree584667b51d7aa63b058606adc8027946ead2046f /chrome/browser/autocomplete/autocomplete_input.cc
parentac8a16bc1ec072211e6e24a781d0bfd19c6ad9b8 (diff)
downloadchromium_src-332d17d2d2889750fd87da90c2d9a796163e981c.zip
chromium_src-332d17d2d2889750fd87da90c2d9a796163e981c.tar.gz
chromium_src-332d17d2d2889750fd87da90c2d9a796163e981c.tar.bz2
Remove AutocompleteInput Type and PageClassification.
They are just as same as the enums defined in .proto files. Removing the declaration of these types reduces unnecessary code dependency to autocomplete. BUG=384232 R=blundell@chromium.org, mpearson@chromium.org, pkasting@chromium.org TBR=brettw@chromium.org, cpu@chromium.org, miguelg@chromium.org, mpcomplete@chromium.org TEST=compile succeeds Review URL: https://codereview.chromium.org/343523003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278722 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete/autocomplete_input.cc')
-rw-r--r--chrome/browser/autocomplete/autocomplete_input.cc16
1 files changed, 9 insertions, 7 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_input.cc b/chrome/browser/autocomplete/autocomplete_input.cc
index fbf04db..69fd111 100644
--- a/chrome/browser/autocomplete/autocomplete_input.cc
+++ b/chrome/browser/autocomplete/autocomplete_input.cc
@@ -8,6 +8,7 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/external_protocol/external_protocol_handler.h"
#include "chrome/browser/profiles/profile_io_data.h"
+#include "components/metrics/proto/omnibox_event.pb.h"
#include "components/url_fixer/url_fixer.h"
#include "content/public/common/url_constants.h"
#include "net/base/net_util.h"
@@ -31,7 +32,7 @@ void AdjustCursorPositionIfNecessary(size_t num_leading_chars_removed,
AutocompleteInput::AutocompleteInput()
: cursor_position_(base::string16::npos),
- current_page_classification_(AutocompleteInput::INVALID_SPEC),
+ current_page_classification_(metrics::OmniboxEventProto::INVALID_SPEC),
type_(metrics::OmniboxInputType::INVALID),
prevent_inline_autocomplete_(false),
prefer_keyword_(false),
@@ -44,7 +45,7 @@ AutocompleteInput::AutocompleteInput(
size_t cursor_position,
const base::string16& desired_tld,
const GURL& current_url,
- AutocompleteInput::PageClassification current_page_classification,
+ metrics::OmniboxEventProto::PageClassification current_page_classification,
bool prevent_inline_autocomplete,
bool prefer_keyword,
bool allow_exact_keyword_match,
@@ -99,7 +100,7 @@ AutocompleteInput::~AutocompleteInput() {
// static
size_t AutocompleteInput::RemoveForcedQueryStringIfNecessary(
- AutocompleteInput::Type type,
+ metrics::OmniboxInputType::Type type,
base::string16* text) {
if ((type != metrics::OmniboxInputType::FORCED_QUERY) || text->empty() ||
(*text)[0] != L'?')
@@ -110,7 +111,8 @@ size_t AutocompleteInput::RemoveForcedQueryStringIfNecessary(
}
// static
-std::string AutocompleteInput::TypeToString(AutocompleteInput::Type type) {
+std::string AutocompleteInput::TypeToString(
+ metrics::OmniboxInputType::Type type) {
switch (type) {
case metrics::OmniboxInputType::INVALID: return "invalid";
case metrics::OmniboxInputType::UNKNOWN: return "unknown";
@@ -124,7 +126,7 @@ std::string AutocompleteInput::TypeToString(AutocompleteInput::Type type) {
}
// static
-AutocompleteInput::Type AutocompleteInput::Parse(
+metrics::OmniboxInputType::Type AutocompleteInput::Parse(
const base::string16& text,
const base::string16& desired_tld,
url::Parsed* parts,
@@ -219,7 +221,7 @@ AutocompleteInput::Type AutocompleteInput::Parse(
url::Parsed http_parts;
base::string16 http_scheme;
GURL http_canonicalized_url;
- AutocompleteInput::Type http_type =
+ metrics::OmniboxInputType::Type http_type =
Parse(http_scheme_prefix + text, desired_tld, &http_parts,
&http_scheme, &http_canonicalized_url);
DCHECK_EQ(std::string(url::kHttpScheme),
@@ -530,7 +532,7 @@ void AutocompleteInput::Clear() {
text_.clear();
cursor_position_ = base::string16::npos;
current_url_ = GURL();
- current_page_classification_ = AutocompleteInput::INVALID_SPEC;
+ current_page_classification_ = metrics::OmniboxEventProto::INVALID_SPEC;
type_ = metrics::OmniboxInputType::INVALID;
parts_ = url::Parsed();
scheme_.clear();