Make starred History*Provider results stay in the autocomplete dropdown, update tests.

Don't delete bookmarked AutoCompleteMatches from the dropdown list, remove their history data and hide their backing store instead. Expose HistoryProvider::DeleteMatch() and add delete tests.

BUG=67822
TEST=New unit tests + Check that starred History*Provider results aren't removed from the omnibox autocomplete dropdown set of matches.

Review URL: http://codereview.chromium.org/6078005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70648 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 3 insertions, 3 deletions

diff --git a/chrome/browser/autocomplete/history_provider.cc b/chrome/browser/autocomplete/history_provider.cc
index 100db04..cbcf691 100644
--- a/chrome/browser/autocomplete/history_provider.cc
+++ b/chrome/browser/autocomplete/history_provider.cc
@@ -43,9 +43,9 @@ void HistoryProvider::DeleteMatch(const AutocompleteMatch& match) {
   for (ACMatches::iterator i(matches_.begin()); i != matches_.end(); ++i) {
     if (i->destination_url == selected_url && i->type == match.type) {
       found = true;
-      if (i->is_history_what_you_typed_match) {
-        // We can't get rid of the What You Typed match, but we can make it
-        // look like it has no backing data.
+      if (i->is_history_what_you_typed_match || i->starred) {
+        // We can't get rid of What-You-Typed or Bookmarked matches,
+        // but we can make them look like they have no backing data.
         i->deletable = false;
         i->description.clear();
         i->description_class.clear();