summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
diff options
context:
space:
mode:
authorsreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-04 04:34:06 +0000
committersreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-04 04:34:06 +0000
commitd4a2a6e246cfb38e317892fa679015b39d2c60e9 (patch)
tree559b57c33a2fdae1e4ec828a303e0e2990778f0d /chrome/browser/autocomplete
parent99eac8cf4a38222eea1d3fc934ca57d0e37a6753 (diff)
downloadchromium_src-d4a2a6e246cfb38e317892fa679015b39d2c60e9.zip
chromium_src-d4a2a6e246cfb38e317892fa679015b39d2c60e9.tar.gz
chromium_src-d4a2a6e246cfb38e317892fa679015b39d2c60e9.tar.bz2
Unlaunch the HIDDEN mode.
Lots of changes: 1. Unlaunch the HIDDEN mode, by putting it back under the UMA guard. This is based on what was decided at Chrome Product Strategy. 2. Eliminate --preload-instant-search, making preloading the default. I think preloading has been around long enough and stable enough that we can do so. 3. Restructure the field trial header, removing convenience methods and letting clients explicitly refer to the modes. I found having to recall what exactly "IsHiddenExperiment()" constituted (HIDDEN? SUGGEST? both?) was a drag. 4. Make SILENT the default, as per Search team's request. So, any time a user in one of the other modes doesn't satisfy the requirements (such as having UMA or suggest enabled), they'll fall through to SILENT. The only exception is if they are in CONTROL. 5. Remove INACTIVE. It's the same as CONTROL anyway. 6. Remove the 'ix' param to stop leaking UMA opt-in state to non-Google sites. 7. Rename "Group" to "Mode" to more accurately reflect the fact that this is the current mode of operation, despite whatever group the user fell into. BUG=none TEST=none Review URL: http://codereview.chromium.org/10353017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135298 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autocomplete')
-rw-r--r--chrome/browser/autocomplete/autocomplete.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/autocomplete/autocomplete.cc b/chrome/browser/autocomplete/autocomplete.cc
index 5d0e73e..1dd1d90 100644
--- a/chrome/browser/autocomplete/autocomplete.cc
+++ b/chrome/browser/autocomplete/autocomplete.cc
@@ -932,7 +932,7 @@ void AutocompleteController::Start(
(text.length() < 6)) {
base::TimeTicks end_time = base::TimeTicks::Now();
std::string name = "Omnibox.QueryTime." + base::IntToString(text.length()) +
- InstantFieldTrial::GetGroupName(profile_);
+ InstantFieldTrial::GetModeAsString(profile_);
base::Histogram* counter = base::Histogram::FactoryGet(
name, 1, 1000, 50, base::Histogram::kUmaTargetedHistogramFlag);
counter->Add(static_cast<int>((end_time - start_time).InMilliseconds()));