This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update the password generation algorithm to contain at least one upper case letter, one lower case letter, one digit, and one other symbol.

BUG=
TEST=PasswordGeneratorTest, AutofillManagerTest, PasswordGenerationManagerTest.


Review URL: https://chromiumcodereview.appspot.com/10458018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140812 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 7 insertions, 0 deletions

diff --git a/chrome/browser/autofill/autofill_manager.h b/chrome/browser/autofill/autofill_manager.h
index e7c011f..d5c5867 100644
--- a/chrome/browser/autofill/autofill_manager.h
+++ b/chrome/browser/autofill/autofill_manager.h
@@ -41,6 +41,10 @@ typedef TabContents TabContentsWrapper;
 
 struct ViewHostMsg_FrameNavigate_Params;
 
+namespace autofill {
+class PasswordGenerator;
+}
+
 namespace content {
 class RenderViewHost;
 }
@@ -96,6 +100,7 @@ class AutofillManager : public content::NotificationObserver,
   void OnShowAutofillDialog();
   void OnDidPreviewAutofillFormData();
   void OnShowPasswordGenerationPopup(const gfx::Rect& bounds,
+                                     int max_length,
                                      const webkit::forms::PasswordForm& form);
 
   // Remove the credit card or Autofill profile that matches |unique_id|
@@ -361,6 +366,8 @@ class AutofillManager : public content::NotificationObserver,
   base::WeakPtr<ProfileSyncService> sync_service_;
   // Listens for changes to the 'enabled' state for password generation.
   PrefChangeRegistrar registrar_;
+  // To be passed to the password generation UI to generate the password.
+  scoped_ptr<autofill::PasswordGenerator> password_generator_;
 
   // Our copy of the form data.
   ScopedVector<FormStructure> form_structures_;