diff options
| author | abodenha@chromium.org <abodenha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-14 18:14:57 +0000 |
|---|---|---|
| committer | abodenha@chromium.org <abodenha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-14 18:14:57 +0000 |
| commit | 606d1080b6d03151a32da36586b4d22b394a8666 (patch) | |
| tree | f7103aa06ebc97102feb9bab565593a58a2839c4 /chrome/browser/autofill/field_types.h | |
| parent | 3f460adc7484c33bd8d8513a219c5f0d0beac50f (diff) | |
| download | chromium_src-606d1080b6d03151a32da36586b4d22b394a8666.zip chromium_src-606d1080b6d03151a32da36586b4d22b394a8666.tar.gz chromium_src-606d1080b6d03151a32da36586b4d22b394a8666.tar.bz2 | |
Revert 176189
Performance regression re-occurred.
> Add support for radiobuttons and checkboxes.
>
> This is attempt no 2 to submit this CL. earlier attempt at
> https://chromiumcodereview.appspot.com/11415221/ (which was rolled back due to perf regression)
>
> Changes from last attempt:
> * In chrome/browser/autofill/form_structure.cc: Read switch value into local variable before being used multiple times.
> * In chrome/renderer/autofill/form_autofill_util.cc: Extracted form_control_type strings in WebString constants for reuse.
>
> Due to inconsistency in the timing reported by the page cycler tests on my local setup and unavailablity of good environment to perform these tests, the only data I have now is runtimes were approximatly same during *one* set of runs with and without my change. I have observed ~4ms difference in timing without any code changes, while I am chasing ~2 ms.
>
> If perf regresssion is observed again on the perf machines, I will revert it back.
>
>
> BUG=157636
>
> Review URL: https://chromiumcodereview.appspot.com/11788025
TBR=ramankk@chromium.org
Review URL: https://codereview.chromium.org/11884020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176685 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill/field_types.h')
| -rw-r--r-- | chrome/browser/autofill/field_types.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/chrome/browser/autofill/field_types.h b/chrome/browser/autofill/field_types.h index d45f1aa..832b94a 100644 --- a/chrome/browser/autofill/field_types.h +++ b/chrome/browser/autofill/field_types.h @@ -6,7 +6,6 @@ #define CHROME_BROWSER_AUTOFILL_FIELD_TYPES_H_ #include <set> -#include <string> // NOTE: This list MUST not be modified. The server aggregates and stores these // types over several versions, so we must remain fully compatible with the @@ -78,12 +77,9 @@ enum AutofillFieldType { COMPANY_NAME = 60, - // Generic type whose default value is known. - FIELD_WITH_DEFAULT_VALUE = 61, - // No new types can be added. - MAX_VALID_FIELD_TYPE = 62, + MAX_VALID_FIELD_TYPE = 61, }; typedef std::set<AutofillFieldType> FieldTypeSet; |