diff options
| author | ramankk@chromium.org <ramankk@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-10 23:05:36 +0000 |
|---|---|---|
| committer | ramankk@chromium.org <ramankk@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-10 23:05:36 +0000 |
| commit | 786a75ce6c3e7128ec6ceae9effb6552c50b8e0b (patch) | |
| tree | 9b4f3590b0e1a6754e2fb0e7dbb45a147a8a12d7 /chrome/browser/autofill/field_types.h | |
| parent | 9e9161b9ecdfe4c17d4230d5f3679a30b906c99b (diff) | |
| download | chromium_src-786a75ce6c3e7128ec6ceae9effb6552c50b8e0b.zip chromium_src-786a75ce6c3e7128ec6ceae9effb6552c50b8e0b.tar.gz chromium_src-786a75ce6c3e7128ec6ceae9effb6552c50b8e0b.tar.bz2 | |
Add support for radiobuttons and checkboxes.
This is attempt no 2 to submit this CL. earlier attempt at
https://chromiumcodereview.appspot.com/11415221/ (which was rolled back due to perf regression)
Changes from last attempt:
* In chrome/browser/autofill/form_structure.cc: Read switch value into local variable before being used multiple times.
* In chrome/renderer/autofill/form_autofill_util.cc: Extracted form_control_type strings in WebString constants for reuse.
Due to inconsistency in the timing reported by the page cycler tests on my local setup and unavailablity of good environment to perform these tests, the only data I have now is runtimes were approximatly same during *one* set of runs with and without my change. I have observed ~4ms difference in timing without any code changes, while I am chasing ~2 ms.
If perf regresssion is observed again on the perf machines, I will revert it back.
BUG=157636
Review URL: https://chromiumcodereview.appspot.com/11788025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176189 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill/field_types.h')
| -rw-r--r-- | chrome/browser/autofill/field_types.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/chrome/browser/autofill/field_types.h b/chrome/browser/autofill/field_types.h index 832b94a..d45f1aa 100644 --- a/chrome/browser/autofill/field_types.h +++ b/chrome/browser/autofill/field_types.h @@ -6,6 +6,7 @@ #define CHROME_BROWSER_AUTOFILL_FIELD_TYPES_H_ #include <set> +#include <string> // NOTE: This list MUST not be modified. The server aggregates and stores these // types over several versions, so we must remain fully compatible with the @@ -77,9 +78,12 @@ enum AutofillFieldType { COMPANY_NAME = 60, + // Generic type whose default value is known. + FIELD_WITH_DEFAULT_VALUE = 61, + // No new types can be added. - MAX_VALID_FIELD_TYPE = 61, + MAX_VALID_FIELD_TYPE = 62, }; typedef std::set<AutofillFieldType> FieldTypeSet; |