summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autofill/form_structure_unittest.cc
diff options
context:
space:
mode:
authorisherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-16 06:19:56 +0000
committerisherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-16 06:19:56 +0000
commit1866d061a07ad56c082f439d5f50301944be4170 (patch)
tree2983cc377e5fe79f41f93fa7354258bee17ec07d /chrome/browser/autofill/form_structure_unittest.cc
parente41c1da3c9b54efaa715b86aeec81a50ee86bfd4 (diff)
downloadchromium_src-1866d061a07ad56c082f439d5f50301944be4170.zip
chromium_src-1866d061a07ad56c082f439d5f50301944be4170.tar.gz
chromium_src-1866d061a07ad56c082f439d5f50301944be4170.tar.bz2
Display a warning when autofill is disabled for a website.
This depends on a WebKit change being tracked at https://bugs.webkit.org/show_bug.cgi?id=49291 BUG=58509 TEST=unit_tests --gtest_filter=AutoFillManagerTest.*:AutoFillHelperTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66214 Review URL: http://codereview.chromium.org/4591001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66237 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/autofill/form_structure_unittest.cc')
-rw-r--r--chrome/browser/autofill/form_structure_unittest.cc48
1 files changed, 25 insertions, 23 deletions
diff --git a/chrome/browser/autofill/form_structure_unittest.cc b/chrome/browser/autofill/form_structure_unittest.cc
index b5881d6..8eb03fd 100644
--- a/chrome/browser/autofill/form_structure_unittest.cc
+++ b/chrome/browser/autofill/form_structure_unittest.cc
@@ -199,7 +199,7 @@ TEST(FormStructureTest, IsAutoFillable) {
ASCIIToUTF16("submit"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_FALSE(form_structure->IsAutoFillable());
+ EXPECT_FALSE(form_structure->IsAutoFillable(true));
// We now have three text fields, but only two auto-fillable fields.
form.fields.push_back(webkit_glue::FormField(ASCIIToUTF16("First Name"),
@@ -213,7 +213,7 @@ TEST(FormStructureTest, IsAutoFillable) {
ASCIIToUTF16("text"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_FALSE(form_structure->IsAutoFillable());
+ EXPECT_FALSE(form_structure->IsAutoFillable(true));
// We now have three auto-fillable fields.
form.fields.push_back(webkit_glue::FormField(ASCIIToUTF16("Email"),
@@ -222,23 +222,25 @@ TEST(FormStructureTest, IsAutoFillable) {
ASCIIToUTF16("text"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
- // The method must be 'post'.
+ // The method must be 'post', though we can intentionally ignore this
+ // criterion for the sake of providing a helpful warning message to the user.
form.method = ASCIIToUTF16("get");
form_structure.reset(new FormStructure(form));
- EXPECT_FALSE(form_structure->IsAutoFillable());
+ EXPECT_FALSE(form_structure->IsAutoFillable(true));
+ EXPECT_TRUE(form_structure->IsAutoFillable(false));
// The target cannot include http(s)://*/search...
form.method = ASCIIToUTF16("post");
form.action = GURL("http://google.com/search?q=hello");
form_structure.reset(new FormStructure(form));
- EXPECT_FALSE(form_structure->IsAutoFillable());
+ EXPECT_FALSE(form_structure->IsAutoFillable(true));
// But search can be in the URL.
form.action = GURL("http://search.com/?q=hello");
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
}
TEST(FormStructureTest, HeuristicsContactInfo) {
@@ -292,7 +294,7 @@ TEST(FormStructureTest, HeuristicsContactInfo) {
ASCIIToUTF16("submit"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
// Expect the correct number of fields.
ASSERT_EQ(9U, form_structure->field_count());
@@ -410,7 +412,7 @@ TEST(FormStructureTest, HeuristicsHiddenFields) {
ASCIIToUTF16("submit"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
// Expect the correct number of fields.
ASSERT_EQ(17U, form_structure->field_count());
@@ -503,7 +505,7 @@ TEST(FormStructureTest, HeuristicsSample8) {
ASCIIToUTF16("submit"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(10U, form_structure->field_count());
ASSERT_EQ(9U, form_structure->autofill_count());
@@ -581,7 +583,7 @@ TEST(FormStructureTest, HeuristicsSample6) {
ASCIIToUTF16("submit"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(7U, form_structure->field_count());
ASSERT_EQ(6U, form_structure->autofill_count());
@@ -655,7 +657,7 @@ TEST(FormStructureTest, HeuristicsLabelsOnly) {
ASCIIToUTF16("submit"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(9U, form_structure->field_count());
ASSERT_EQ(8U, form_structure->autofill_count());
@@ -716,7 +718,7 @@ TEST(FormStructureTest, HeuristicsCreditCardInfo) {
ASCIIToUTF16("submit"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(6U, form_structure->field_count());
ASSERT_EQ(4U, form_structure->autofill_count());
@@ -778,7 +780,7 @@ TEST(FormStructureTest, HeuristicsCreditCardInfoWithUnknownCardField) {
ASCIIToUTF16("submit"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(7U, form_structure->field_count());
ASSERT_EQ(4U, form_structure->autofill_count());
@@ -829,7 +831,7 @@ TEST(FormStructureTest, ThreeAddressLines) {
ASCIIToUTF16("text"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(4U, form_structure->field_count());
ASSERT_EQ(3U, form_structure->autofill_count());
@@ -875,7 +877,7 @@ TEST(FormStructureTest, BillingAndShippingAddresses) {
ASCIIToUTF16("text"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(4U, form_structure->field_count());
ASSERT_EQ(4U, form_structure->autofill_count());
@@ -925,7 +927,7 @@ TEST(FormStructureTest, ThreeAddressLinesExpedia) {
ASCIIToUTF16("text"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(4U, form_structure->field_count());
ASSERT_EQ(3U, form_structure->autofill_count());
@@ -966,7 +968,7 @@ TEST(FormStructureTest, TwoAddressLinesEbay) {
ASCIIToUTF16("text"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(3U, form_structure->field_count());
ASSERT_EQ(3U, form_structure->autofill_count());
@@ -1002,7 +1004,7 @@ TEST(FormStructureTest, HeuristicsStateWithProvince) {
ASCIIToUTF16("text"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(3U, form_structure->field_count());
ASSERT_EQ(3U, form_structure->autofill_count());
@@ -1087,7 +1089,7 @@ TEST(FormStructureTest, HeuristicsWithBilling) {
ASCIIToUTF16("text"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(11U, form_structure->field_count());
ASSERT_EQ(11U, form_structure->autofill_count());
@@ -1136,7 +1138,7 @@ TEST(FormStructureTest, ThreePartPhoneNumber) {
ASCIIToUTF16("text"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
ASSERT_EQ(4U, form_structure->field_count());
ASSERT_EQ(3U, form_structure->autofill_count());
@@ -1207,7 +1209,7 @@ TEST(FormStructureTest, MatchSpecificInputTypes) {
ASCIIToUTF16("submit"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
// Expect the correct number of fields.
ASSERT_EQ(10U, form_structure->field_count());
@@ -1266,7 +1268,7 @@ TEST(FormStructureTest, HeuristicsInfernoCC) {
ASCIIToUTF16("text"),
0));
form_structure.reset(new FormStructure(form));
- EXPECT_TRUE(form_structure->IsAutoFillable());
+ EXPECT_TRUE(form_structure->IsAutoFillable(true));
// Expect the correct number of fields.
ASSERT_EQ(5U, form_structure->field_count());
generated by cgit v1.1 at 2025-03-28 03:49:54 +0000